Repository navigation
Show a report's note: to its sender on /club, on its page once published, and on its board - #410
Merged
Merged
Conversation
…hed, and on its board An owner asked whether the "Anything else: where you bought it, what it is sold as" field is kept: it is, as written for the maintainers and redacted for the public (note_public, migration 018), but nothing showed it -- not /club, not the report's page, not the board it was published on. - /club lists the member's own note beside each of their reports, as they wrote it. - The report's page shows the owner's note once the report is published; the service serves only the redacted copy, and only then. - A published report's note becomes the note of the unit it makes on its board (board_units.notes, which the board panel already shows), redacted. Units already made pick it up on the next refresh.
PR Summary by QodoShow report notes to senders and on published reports and boards
AI Description
Diagram
High-Level Assessment
Files changed (12)
|
Code Review by Qodo
1.
|
![qodo-free-for-open-source-projects[bot]](https://avatars.githubusercontent.com/in/1068000?s=60&v=4){kind=small}
…board unit PublishedTexts joined only reports with a served text or photo file, so a note sent alone, or beside a private backup, reached no board. The files are joined optionally now, and a report with a published note is listed without them; a private backup still never goes with it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An owner asked in the OpenIPC chat whether the "Anything else: where you bought it, what it is sold as" field is kept. It is: the note as written is stored for the maintainers, and a redacted copy for the public (
note_public, migration 018). But nothing showed it: not/club, not the report's page, and not the board the report was published on.Changes
/club: each of the member's reports now shows "Your note: …", exactly as they wrote it (club/Club.tsx).reports/Receipt.tsx). The service already serves only the redacted copy, and only after publishing (Store.Public).PublishedTextscarriesnote_public, andrefreshReportUnitspasses it on as the unit's note (board_units.notes, which the board panel already shows). Units already made from published reports pick their notes up on the next refresh, which runs at service start.Tests
club,TestTheSendersNoteIsShownAndPublishedRedacted: the sender sees the note as written, and the published note going onto the board has the pasted MAC replaced by its keyed hash.club/Notes.test.tsx: the note on/cluband on a published report's page. Both tests fail without the change.service/run.sh test: all 22 packages pass, and gofmt is clean. Frontend lint, typecheck, tests (706) and build pass, and the bundle check passes.Not yet done