Skip to content

fix(about): show the real version on Android and iOS - #81

Merged
keyldev merged 1 commit into
mainfrom
fix/about-version
Oct 2, 2026
Merged

keyldev merged 1 commit into
mainfrom
fix/about-version

Conversation

@keyldev

@keyldev keyldev commented Oct 2, 2026 •

Copy link
Copy Markdown
Collaborator
  • read the version from the App assembly: GetEntryAssembly() is null on mobile, so About fell through to the hard-coded 0.1.0
  • repository link points at OpenIPC/viewer

Summary

Related

Type

  • Bug fix
  • Feature
  • Refactor / cleanup
  • Docs / CI
  • Other:

Checklist

  • Builds with 0 warnings (TreatWarningsAsErrors=true).
  • Tests pass (dotnet test); new Core logic has unit tests.
  • No layering violation — App references Core only (Infrastructure / Video / Devices wired via DI in a head).
  • Scope stays within one phase (didn't pull work from a later phase's "Не входит").
  • README / docs updated if public commands, options, or setup changed.

Platforms tested

  • Windows
  • Linux
  • macOS
  • Android
  • iOS
  • CI build only

Screenshots / notes

- read the version from the App assembly: GetEntryAssembly() is null on
  mobile, so About fell through to the hard-coded 0.1.0
- repository link points at OpenIPC/viewer
@keyldev
keyldev merged commit 134b6ed into main Oct 2, 2026
5 checks passed
@qodo-free-for-open-source-projects

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can show, collapse, or hide each part of a finding: code, evidence, and all

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@qodo-free-for-open-source-projects

Copy link
Copy Markdown

PR Summary by Qodo

Show the correct version and repository link in About

🐞 Bug fix 🕐 Less than 10 minutes

Grey Divider

AI Description

• Show the app's git-derived version in About on Android and iOS instead of the fallback.
• Point the repository and issue links to OpenIPC/viewer.
Diagram

graph TD
  Build["Git-derived version"] --> Assembly["App assembly"] --> VM["Settings view model"] --> About["About page"]
  VM --> Repo["GitHub repository"]
Loading
High-Level Assessment

Reading the view model's assembly is appropriate because the shared build target assigns the same git-derived version to each project, while the entry assembly can be absent on mobile. Keeping the existing informational-version preference and fallbacks limits the change's scope.

Files changed (1) +6 / -3

Bug fix (1) +6 / -3
SettingsPageViewModel.csRead About version from the App assembly and correct repository URL +6/-3

Read About version from the App assembly and correct repository URL

• Replaces entry-assembly lookup with the view model's assembly so mobile builds can display their informational version, while retaining numeric and hard-coded fallbacks. Changes the repository URL to OpenIPC/viewer, which also corrects the issue-report destination.

src/OpenIPC.Viewer.App/ViewModels/SettingsPageViewModel.cs

@keyldev
keyldev deleted the fix/about-version branch October 2, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant