gk7205v500: build the V4 sensor drivers from their one source

[widgetii]

#229 added libraries/sensor/gk7205v500/imagedesign_mis2008, a copy of the
hi3516ev200 MIS2008 driver with GK_* renamed to XMEDIA_*. That is the same
driver twice: the XMedia SPC020 sensor interface is the V4 one rebranded,
the same relationship HiSilicon's and Goke's already have and that
include/hicompat.h bridges for the V4 drivers.

So the copy goes, and CHIPARCH=gk7205v500 builds sensor/hi3516ev200 like
the other V4 targets. sensor/compat/xmedia maps the drivers' Goke names
onto the SDK:

• xm_gk_compat.h: GK_/gk_ types and constants onto XMEDIA_*. Force-
  included: the drivers often get the Goke types only through the SDK
  headers, and those include their own type.h relative to themselves, so
  shadowing type.h on the include path cannot reach them;
• gk_api_{isp,ae,awb}.h, hicompat.h: GK_API_* onto XMEDIA_API_*, with the
  SDK's own prototypes.

libraries/Makefile puts these and the SDK headers imported under kernel/
ahead of the V4 include/ the per-sensor Makefiles add; no driver or
per-sensor Makefile changes.

All 30 V4 sensor drivers now build for gk7205v500 (before: only MIS2008,
as the copy), with no warning the gk7205v200 build of the same sources
does not already have; gk7205v200 still builds all 30. On the GK7201V200 /
MIS2008 camera the shared-source libsns_mis2008.so initialises the sensor
and majestic streams 1080p25 H.264 with a correct image.

[qodo-free-for-open-source-projects]

PR Summary by Qodo

Build gk7205v500 V4 sensor drivers from shared sources

✨ Enhancement ⚙️ Configuration changes 🕐 20-40 Minutes

AI Description

• Build all shared V4 sensor drivers for gk7205v500 through XMedia compatibility headers.
• Translate Goke types and ISP, AE, and AWB callbacks onto XMedia SDK APIs.
• Remove the duplicated XMedia-only MIS2008 driver implementation.

Diagram

graph TD
  A["gk7205v500 Build"] --> B["V4 Drivers"] --> C["Sensor Libraries"]
  A --> D["XMedia Flags"] --> E["Compat Headers"] --> F["XMedia SDK"]
  E --> B

Loading

High-Level Assessment

The compatibility-layer approach is the best fit because SPC020 is the V4 interface under different names. It preserves one source of truth for all 30 drivers and avoids either maintaining copied platform ports or adding XMedia conditionals throughout every sensor source and Makefile.

Files changed (6) +117 / -6

Enhancement (5) +101 / -0

gk_api_ae.hMap Goke AE callbacks to XMedia APIs +11/-0

Map Goke AE callbacks to XMedia APIs

• Provides the Goke AE header name expected by shared drivers while importing native XMedia declarations. Registration and unregistration calls are aliased to their XMedia equivalents.

libraries/sensor/compat/xmedia/gk_api_ae.h

gk_api_awb.hMap Goke AWB callbacks to XMedia APIs +11/-0

Map Goke AWB callbacks to XMedia APIs

• Provides the expected Goke AWB compatibility header and maps sensor registration callbacks onto the native XMedia AWB API.

libraries/sensor/compat/xmedia/gk_api_awb.h

gk_api_isp.hMap Goke ISP callbacks to XMedia APIs +12/-0

Map Goke ISP callbacks to XMedia APIs

• Adapts Goke ISP registration, unregistration, and module-parameter API names to the corresponding XMedia SDK functions while retaining native prototypes.

libraries/sensor/compat/xmedia/gk_api_isp.h

hicompat.hRoute shared driver compatibility includes through XMedia +13/-0

Route shared driver compatibility includes through XMedia

• Shadows the standard V4 compatibility header for XMedia builds. It aggregates the ISP, AE, and AWB adapters so existing driver includes resolve without source changes.

libraries/sensor/compat/xmedia/hicompat.h

xm_gk_compat.hTranslate Goke primitive types and constants to XMedia +54/-0

Translate Goke primitive types and constants to XMedia

• Defines the uppercase and lowercase Goke primitive types, status values, booleans, and null constant expected by V4 drivers. The header is designed for forced inclusion because SDK-relative type headers cannot be shadowed through include-path ordering.

libraries/sensor/compat/xmedia/xm_gk_compat.h

Other (1) +16 / -6

MakefileBuild shared V4 drivers with XMedia compatibility flags +16/-6

Build shared V4 drivers with XMedia compatibility flags

• Selects the hi3516ev200 V4 sensor directories for gk7205v500 instead of a target-specific sensor tree. It prepends compatibility and XMedia SDK include paths, force-includes the type adapter, and forwards those flags into each sensor build.

libraries/Makefile

[qodo-free-for-open-source-projects]

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Tip of the day

💡 Did you know, you can enable the Remediation agent and Qodo fixes findings in a dedicated fix PR

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

[widgetii]

Added b1f1711: the shared V4 MIS2008 driver read Dgain_table with a hard-coded size of 255 (the table has 240 entries), so the Dgain saturation check read past the table and, in the optimised firmware build, returned a digital gain of 0 -- AE then ran on ~4x ISP gain and the image was noisy and yellow. Found while testing the gk7201v200_lite firmware build of this branch on the GK7201V200/MIS2008 camera; with the fix the same build and scene give Dgain 1024, ISO 843 and a clean image. The bug predates this PR and affects the hi3516ev200/gk7205v200 builds too.