Repository navigation
sysupgrade: say what --kernel, --rootfs, -k and -r take on each layout - #2539
Merged
Merged
Conversation
The help said --kernel takes a uImage and --rootfs a squashfs. The kernel can also be a FIT (cv6xx) or zboot.img (Rockchip). On a UBIFS NAND camera (root=ubi0:rootfs) the rootfs is rootfs.ubifs and carries the kernel: -k and -r both write it, and --kernel on its own is refused with a pointer to --rootfs. The help now says so.
Code Review by Qodo🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)
Great, no issues found!Qodo reviewed your code and found no material issues that require reviewTip of the day💡 Did you know, you can describe a rule in plain language on the Rules page and Qodo drafts it for you |
PR Summary by QodoClarify sysupgrade image formats by device layout
AI Description
Diagram
High-Level Assessment
Files changed (1)
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The help said
--kerneltakes a uImage and--rootfsa squashfs. That is only part of it:--kernelalso takes a FIT (cv6xx), orzboot.imgon Rockchip.root=ubi0:rootfs, the layout from nand: kernel inside the UBIFS rootfs, volumes sized by their images; retire the old NAND layouts #2537) the rootfs isrootfs.ubifsand carries the kernel.-kand-rboth write it, and--kernelon its own is refused with a pointer to--rootfs.The help now says so. Help text only; no behaviour changes.
sh -npasses, and.github/scripts/test_sysupgrade.shpasses on top of #2538.