Skip to content

Follow-ups from the PR #81 review #91

Description

@aaronmbauman

The MS-Word to AsciiDoc conversion is in #90, squashed from the review branch in
#81. During that review @mbeckerle raised a number of points we agreed to handle
after the conversion lands rather than before. This collects them, at his
suggestion:

Agree this can be handled later. We just need to keep a list of these. If you
want to you can make a single umbrella issue and put a list of these changes
in it rather than one issue per.

None of them block #90. They are presentation and refactoring work on a
conversion whose text fidelity is already checked by make check-conversion.
Line references are against spec-conversion, the branch in #90.

Rendering

A double hyphen where a single minus sign is intended.
spec/clauses/14-sequence-groups.adoc lines 610 and 613, two cells of the
occursCountKind table. The source carries pass-format:straightquotes[--] and
it renders as -- N). Still reproduces in the current build.
#81 comment

Inner bullets are too big.
Set by :presentation-metadata-ul-label-list: in both masters, currently
•,○,▪. Seen in 13-simple-types.adoc and F-specific-errors-classified.adoc.
Mike notes it is not true everywhere, so this wants checking level by level
rather than a blind swap of the marker.
#81 comment,
and here

Indentation in a section of 13-simple-types.adoc.
The lines are indented in the original. [align=indent] is applied in places,
so this needs checking against the source rather than assuming it is missing.
#81 comment

Bulleted lists are not dense enough.
About 2pt more between item starts than GFD.240. A list item body is a paragraph
block carrying an 8pt margin and the stylesheet's list-item styles are empty, so
no document attribute reaches it. Needs an override in spec/pdf-overrides.xsl.
#81 comment

Front matter and page furniture

Header and footer size and content.
The content is data-driven and already follows the edition: the ISO build prints
ISO 23415:2026(en) and the OGF build Open Grid Forum 240:2026(en), from
:publisher: and :docnumber:. The layout itself belongs to the stylesheet's
page masters, so matching GFD.240 exactly needs more than an attribute.
#81 comment

Front matter sections, their order and formatting.
Mike's position is that this is lower priority than establishing that the body
conversion is faithful, and is minor refactoring better done by hand afterwards
than taught to the converter.
#81 comment

Is :mn-document-class: iso correct for the OGF edition?
spec/dfdl-ogf.adoc line 9. Asked during the review and not yet answered.
#81 comment

Review tooling

Change markings and a JTC 1 review edition.
The change marks survive in the .docx: 79 insertions and 29 deletions across
28 paragraphs, in two batches dated 2025-12-29 and 2026-01-16. Metanorma has
add:[] and del:[], which render underlined and struck through in red, so an
edition showing just the changes is buildable. Parked pending a decision on
whether that is what OGF and ISO reviewers should be given.
#81 comment

Possibly errata rather than conversion

AlignmentFill should be bold-italic, and alignmentUnits wants a dfdl:
prefix
, in spec/clauses/12-framing.adoc. Mike marked this one a content
change. If that is right it belongs with the errata issues rather than here.
#81 comment

Spec text errata found during the conversion are tracked separately in #82
through #89.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions