Skip to content

ci: integration-tests regression example - #5193

Open
doc-han wants to merge 1 commit into
mainfrom
demo-worker-socket-path
Open

doc-han wants to merge 1 commit into
mainfrom
demo-worker-socket-path

Conversation

@doc-han

@doc-han doc-han commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

Description

This PR intentionally updates the worker socket connection path.

Closes #__

Validation steps

  1. (How can a reviewer validate your work?)

Additional notes for the reviewer

  1. (Is there anything else the reviewer should know or look out for?)

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

Pre-submission checklist

  • I have performed an AI review of my code (we recommend using /review
    with Claude Code)
  • I have implemented and tested all related authorization policies.
    (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

@github-project-automation github-project-automation Bot moved this to New Issues in Core Sep 17, 2026
@github-actions

Copy link
Copy Markdown

Security Review ✅

  • S0 (project scoping): N/A — the PR only renames the worker WebSocket path from /worker to /worker/socket in lib/lightning_web/endpoint.ex:23 and matches it in lib/lightning/runtime/runtime_manager.ex:108; no data queries changed.
  • S1 (authorization): N/A — no new web-layer actions; WorkerSocket.connect/3 still gates on Workers.verify_worker_token/1 (lib/lightning_web/channels/worker_socket.ex:32), unchanged.
  • S2 (audit trail): N/A — no config-resource writes introduced.

@codecov

codecov Bot commented Sep 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.9%. Comparing base (98665f1) to head (d53f2d9).

Additional details and impacted files
@@           Coverage Diff           @@
##            main   #5193     +/-   ##
=======================================
- Coverage   91.0%   90.9%   -0.1%     
=======================================
  Files        425     425             
  Lines      21156   21156             
=======================================
- Hits       19243   19232     -11     
- Misses      1913    1924     +11     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: New Issues

Development

Successfully merging this pull request may close these issues.

1 participant