Skip to content

webhook: use 200 instead of 201 for the default success response - #5192

Closed
doc-han wants to merge 1 commit into
mainfrom
demo-webhook-status-break
Closed

doc-han wants to merge 1 commit into
mainfrom
demo-webhook-status-break

Conversation

@doc-han

@doc-han doc-han commented Sep 17, 2026

Copy link
Copy Markdown
Contributor

More conventional for a synchronous request that returns a body - 201 implies a created resource, which a webhook trigger doesn't map to.

Description

This PR [adds/changes/fixes]... (A description of your work goes here.)

Closes #__

Validation steps

  1. (How can a reviewer validate your work?)

Additional notes for the reviewer

  1. (Is there anything else the reviewer should know or look out for?)

AI Usage

Please disclose whether you've used AI anywhere in this PR (it's cool, we just
want to know!):

  • I have used Claude Code
  • I have used another model
  • I have not used AI

You can read more details in our
Responsible AI Policy

Pre-submission checklist

  • I have performed an AI review of my code (we recommend using /review
    with Claude Code)
  • I have implemented and tested all related authorization policies.
    (e.g., :owner, :admin, :editor, :viewer)
  • I have updated the changelog.
  • I have ticked a box in "AI usage" in this PR

More conventional for a synchronous request that returns a body -
201 implies a created resource, which a webhook trigger doesn't map to.
@github-project-automation github-project-automation Bot moved this to New Issues in Core Sep 17, 2026
@github-actions

Copy link
Copy Markdown

Security Review ✅

  • S0 (project scoping): N/A — the diff only changes a hard-coded HTTP status literal (run_channel.ex:483), no queries or project data access are touched.
  • S1 (authorization): N/A — no new controller/channel/LiveView actions or policy changes; the existing gate on RunChannel is untouched.
  • S2 (audit trail): N/A — no writes to project/instance configuration resources; only the default success status code is changed.

@doc-han doc-han closed this Sep 17, 2026
@github-project-automation github-project-automation Bot moved this from New Issues to Done in Core Sep 17, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

1 participant