CI - REFACTOR - Remove the auto-merge label wrapper workflow - #405
Open
logan-nc wants to merge 1 commit into
Open
CI - REFACTOR - Remove the auto-merge label wrapper workflow#405logan-nc wants to merge 1 commit into
logan-nc wants to merge 1 commit into
Conversation
The workflow only called `gh pr merge --auto`, which is GitHub's own auto-merge. With `allow_auto_merge` enabled on the repository, the merge box button offers the same capability directly, so the label added a second path to arming a merge without adding any function. It also widened access slightly: the workflow merged using GITHUB_TOKEN, so anyone able to apply a label could arm auto-merge even without permission to merge. The button requires write access. The `auto-merge` label has been deleted; no open pull request carried it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Release note
auto-mergelabel. The label has been deleted.Removes the custom auto-merge workflow. GitHub's native auto-merge, which the workflow was only triggering, covers the same capability directly.
Why
.github/workflows/auto-merge.yamldid not implement merging. It rangh pr merge --auto, which is GitHub's native auto-merge — so the workflow was a label-driven trigger for the merge-box button, nothing more.allow_auto_mergeistrueon this repository, so the button is already available to anyone with write access and no capability is lost.Two reasons to prefer the button over the label:
GITHUB_TOKEN, so anyone able to apply a label could arm auto-merge even without permission to merge it themselves. The button requires write access.The one thing lost is at-a-glance visibility: a label shows in the pull request list, whereas the button's state only shows inside the PR.
Regression report
No files under
src/are touched; the change deletes a single workflow file, so there is nothing for the harness to move.Notes for reviewers
The
auto-mergelabel has already been deleted, and no open pull request was carrying it, so nothing in flight was disturbed. With the label gone the workflow is inert regardless, but leaving a dead workflow that holdscontents: writeis worse than removing it.Branch protection on
developis unchanged by this and still requires one approving review plus theDocumentationandTestschecks — native auto-merge waits on those exactly as the label-driven path did.The title follows the commit convention proposed in #404. Note that the
pr-conventionscheck will not run on this PR, because that workflow does not exist ondevelopyet.