Remapping#54
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a name remapping mechanism to the Cyphal “cy” node, wiring it into name resolution and providing configuration via a simple from=to string format. This is integrated into the public API/docs, examples, and test suite.
Changes:
- Implemented
cy_remap()/cy_remap_parse()and applied remap rules duringcy_resolve()/cy_name_resolve(). - Extended
cy_name_resolve()to accept an optional WKV remap table and updated tests accordingly. - Added new integration tests for remapping, updated examples to read
CYPHAL_NAMESPACE/CYPHAL_REMAP, and documented remapping in the README.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
cy/cy.c |
Adds remap storage to cy_t, implements remap APIs, and applies remap in name resolution. |
cy/cy.h |
Documents remapping and changes cy_name_resolve() signature to accept a remap table. |
tests/src/test_api_remap.cpp |
New integration tests for remap insertion/overwrite, parsing, pin behavior, OOM rollback, and destroy cleanup. |
tests/src/test_api_name.cpp |
Updates call sites for the new cy_name_resolve(remap, ...) signature and adds unit-style remap tests using WKV directly. |
tests/CMakeLists.txt |
Adds the new remap test target to the API test matrix. |
README.md |
Documents the remapping feature and environment-variable based configuration convention. |
examples/example_time_pub.c |
Reads namespace/remap from environment and applies cy_remap_parse(). |
examples/example_streaming_server.c |
Reads namespace/remap from environment and applies cy_remap_parse(). |
examples/example_streaming_client.c |
Reads namespace/remap from environment and applies cy_remap_parse(). |
examples/example_file_server.c |
Reads namespace/remap from environment and applies cy_remap_parse(). |
examples/example_file_client.c |
Reads namespace/remap from environment and applies cy_remap_parse(). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #23