Skip to content

Commit 4cc21df

Browse files
committed
fix(ci): release workspace build + add bundler smoke to ci
Two CI fixes surfaced by the v0.1.0 tag push: - release.yml: the "Build workspace" step ran \`pnpm -r build --filter '!@open-codesign/desktop'\`, which pnpm parsed as "run the recursive build script and pass --filter through as args". With no package having a build script, pnpm fell into desktop's build and forwarded --filter to electron-builder, which choked on the unknown argument. Fix by putting --filter BEFORE -r / the script: \`pnpm --filter '!@open-codesign/desktop' -r build\`. - ci.yml: add a bundler smoke step that runs \`electron-vite build\` on every push. Catches broken imports, missing assets, and bad vite config on main instead of only when a tag release lights up. Skip electron-builder packaging (that still lives in release.yml where the runner-minute cost is justified).
1 parent e527f26 commit 4cc21df

2 files changed

Lines changed: 7 additions & 1 deletion

File tree

.github/workflows/ci.yml

Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -40,6 +40,12 @@ jobs:
4040
- name: Test
4141
run: pnpm test
4242

43+
# Build smoke — bundle the Electron main + renderer so broken imports,
44+
# missing assets, or bad vite config fail here instead of only during a
45+
# tag release. Skip electron-builder packaging (that's release.yml's job).
46+
- name: Build smoke (electron-vite bundle)
47+
run: pnpm --filter @open-codesign/desktop exec electron-vite build
48+
4349
dco:
4450
name: DCO check
4551
runs-on: ubuntu-latest

.github/workflows/release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -156,7 +156,7 @@ jobs:
156156

157157
# Build all workspace packages (turborepo respects dep graph)
158158
- name: Build workspace
159-
run: pnpm -r build --filter '!@open-codesign/desktop'
159+
run: pnpm --filter '!@open-codesign/desktop' -r build
160160

161161
# Package the Electron app.
162162
# CSC_IDENTITY_AUTO_DISCOVERY=false: skip ad-hoc Mac signing prompt.

0 commit comments

Comments
 (0)