fix(conformance): bind merged Chat retained-handle repair - #235
Open
BunsDev wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Documentation and the independent Windows source fixture must be synchronized with the new binding.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Rebinds protected conformance validation to merged Chat #256 and refreshes related identities, fixtures, and documentation.
Changes:
- Updates producer, workflow, bootstrap, and supervisor identities.
- Refreshes conformance tests and lock metadata.
- Revises release and workflow documentation.
File summaries
| File | Description |
|---|---|
tests/conformance-gaps.spec.ts |
Updates conformance identity and fixture expectations. |
tests/conformance-contract.spec.ts |
Verifies the new producer and source revision. |
scripts/github-conformance-evidence.mjs |
Updates reviewed source and bootstrap gates. |
RELEASING.md |
Documents the Chat #256 binding and protected run. |
docs/workflows/client-v1-cross-repository-conformance.md |
Updates workflow binding documentation. |
conformance/client-v1-cross-repository-lock.json |
Rebinds frozen producer metadata. |
The workflow documentation still contains superseded Chat #257/run details, and the independent Windows supervisor source fixture remains bound to the previous identity.
Review details
Suppressed comments (1)
scripts/github-conformance-evidence.mjs:33
- The new reviewed-source identity no longer matches the independent source gate in
tests/windows-supervisor-source.spec.ts:8, which still bindschat-debee-windows-supervisor.cs.brto the previous 349530-byteb7ec...source. Update that fixture and identity together with this retained-handle source, otherwise the independent test continues to validate the old supervisor while the workflow verifier accepts the new one (or fails against a refreshed fixture).
const REVIEWED_WINDOWS_SUPERVISOR_SOURCE = Object.freeze({
size: 350211,
sha256: '20b7881696e00dd9f1aae780fdeb9474d4144c76d030f272eceb05a0caae5c2d',
- Files reviewed: 6/9 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+30
to
+31
| This binding selects merged Chat #257 producer `e6bf92c6ec47fd6a5e859afa17db314618b1c2c5`, | ||
| pinning harness source revision `719cb5d6e0653956773743522b9267b87a5e9b05` |
This was referenced Sep 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bind protected conformance validation to merged Chat #256 producer
e6bf92c6ec47fd6a5e859afa17db314618b1c2c5, preserving its tested tree and signed frozen source719cb5d6e0653956773743522b9267b87a5e9b05. Refresh exact workflow/bootstrap fixtures and the independent decoded Windows supervisor identity for the retained-handle termination repair. Candidate packages and counterpart revisions remain unchanged.Validation
corepack pnpm@10.34.0 verify:repositorypasses:1515 tests,2 skipped; coverage and all3 stress seeds pass; typecheck, package checks, and lint pass.verifyincludes a separate development release configuration gate; this PR uses repository verification and does not claim release readiness.Release impact
Publishing remains disabled. After verified SDK landing, rotate both validator scopes to the actual merge and obtain fresh protected records and attestations. Previous protected34746733029 passed independently checked Linux/macOS identity, timing, and197 ordered assertions, but Windows failed quota enumeration before launch; aggregate validation and attestation were skipped. Preserve chat and active worktrees.
Review corrections
Comment3999243669 and the suppressed source-fixture finding are addressed: the workflow documentation now names merged Chat #256 and protected34746733029, and the independent compressed C# fixture matches the actual merged source. A new regression directly compares that independent fixture with the embedded workflow source; it failed before the fixture refresh and passes afterward. The correction passed82 focused contract/source tests (1 skipped), typecheck, lint, secret hooks, and independent review. Full repository verification passed on the preceding binding commit; fresh CI covers this correction. No review-thread flags were changed.