fix(conformance): bind merged Chat pairing diagnostics - #232
Merged
Conversation
Contributor
There was a problem hiding this comment.
Warning
Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.
Pull request overview
Updates the protected conformance binding to the merged OpenCoven/chat#254 producer, rotating associated workflow/bootstraps digests and refreshing fixtures/docs to support new bounded pairing diagnostics (incl. Windows pairing failure categories).
Changes:
- Rotated pinned Chat producer commit/tree and updated harness/workflow byte digests in lock + tests.
- Updated bootstrap script SHA-256 constants (Windows parent/child, Unix preparation) and refreshed workflow contract fixtures.
- Updated release and workflow documentation to describe the new binding and the Windows pairing diagnostic context.
Reviewed changes
Copilot reviewed 6 out of 9 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/conformance-gaps.spec.ts | Updates expected producer metadata and digest assertions to match the new Chat merge binding. |
| tests/conformance-contract.spec.ts | Refreshes workflow fixture expectations for new commit and harness revision references. |
| scripts/github-conformance-evidence.mjs | Rotates reviewed bootstrap SHA-256 constants used by the evidence collector. |
| docs/workflows/client-v1-cross-repository-conformance.md | Updates narrative documentation to reflect the new Chat #254 binding and diagnostics rationale. |
| conformance/client-v1-cross-repository-lock.json | Rotates the pinned evidence producer metadata and reviewed digests to the new merge binding. |
| RELEASING.md | Refreshes release guidance text to reflect the new producer binding and Windows pairing context. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+55
to
+59
| 'e97f1e6c0225dd041b2150e355f968ed06cc6d56bef285b2849a22b1bdf14509'; | ||
| const REVIEWED_WINDOWS_CHILD_BOOTSTRAP_SHA256 = | ||
| '2bcbb2fd519301db5a22686b96c1ad4f322289dd56f10969a8d9939cee6ee8e5'; | ||
| 'bb3578715a67e2ff50f432e51353f0db50e95025db4e9484b7bc2bcb7404e79e'; | ||
| const REVIEWED_UNIX_SUPERVISOR_PREPARATION_SCRIPT_SHA256 = | ||
| '3d486717e471c739612ce00db2c69b620530e67bf230b04aec37cf68625ef428'; | ||
| '6623fe3ddafd4126acec6e194d5cc34069ddbe49a94a861cc13312d53122a03e'; |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Bind the protected conformance validator to merged OpenCoven/chat#254 at
9a750513f3ffc7a09242993b6b1fac9e2ff88207, tree96c132953431c6ba627a2d3a1ac40ae5c1fd0c84, retaining signed harness sourcee7b9d73cfb3c067333bb2c78194b2cad6e16a34c. Chat adds bounded pairing diagnostics, including pairing_pending, to identify the Windows failure seen in protected run 34734409422.Rotate exact producer metadata and all three bootstrap digests (Windows parent, Windows child, Unix preparation), refresh workflow fixtures, and update release/conformance documentation. Counterpart revisions and mandatory decoded supervisor validation remain unchanged.
Validation
corepack pnpm@10.34.0 verify:repositorypasses on the actual merge binding: 1,515 tests, two skipped; packed-package checks; coverage; three stress runs of six tests; lint.Changeset: not applicable; private conformance binding only. Chat's exact-head CI 34736339002 passed all ten jobs before its signed merge.
Release impact
No publication authorization. SDK #38 remains open. After this verified binding lands, rotate both Chat validator scopes to the actual SDK merge and obtain fresh protected validation. Prior run 34734409422 passed Linux/macOS but failed Windows pairing; it produced no accepted aggregate. Chat and active worktrees remain preserved.
Review disposition: clarified “harness source revision” in both documents (3998726685); focused contract/gap suites pass 80 tests with one skipped after the wording change. Retained independent reviewed bootstrap digest constants (3998726694): the validator compares the lock and downloaded workflow against separately reviewed constants. Deriving those expected constants from the same lock would remove that independent check. Existing drift tests remain mandatory.