fix(conformance): bind latest Chat authority - #231
Closed
BunsDev wants to merge 1 commit into
Closed
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Member
Author
|
Superseded by merged #230, which binds the same Chat c487e294 authority with passing checks. |
9 tasks
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Refresh the Windows supervisor fixture and update the stale timeout documentation.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Rebinds conformance validation to merged OpenCoven/chat#251 and refreshes related evidence, fixtures, tests, and documentation.
Changes:
- Updates producer, workflow, script, and fixture identities.
- Regenerates deterministic Brotli fixtures.
- Synchronizes conformance tests and release documentation.
File summaries
| File | Summary |
|---|---|
tests/windows-supervisor-source.spec.ts |
Updates the supervisor source fixture identity. |
tests/conformance-gaps.spec.ts |
Rebinds fixture and producer expectations. Moderate (2 votes): the Windows supervisor fixture still targets chat-55071 and needs refreshing. |
tests/conformance-contract.spec.ts |
Updates the expected producer revision. |
scripts/github-conformance-evidence.mjs |
Refreshes reviewed script hashes. |
RELEASING.md |
Updates producer references. Nit (1 vote): timeout documentation is stale for Chat #251. |
docs/workflows/client-v1-cross-repository-conformance.md |
Updates conformance documentation. Nit (1 vote): timeout documentation is stale for Chat #251. |
conformance/client-v1-cross-repository-lock.json |
Records the updated Chat authority metadata. |
Review details
Suppressed comments (2)
RELEASING.md:216
- This new Chat #251 binding leaves the timeout statement below inconsistent with the selected producer: #251's
caveLaunchRpcTimeoutForPlatformreturns30_000 + rpcTimeoutMson all platforms (40 seconds around 30 seconds), so Windows does not have the documented 85/75-second budget. Please update this copy together with the matching workflow document.
Chat #251 producer `c487e29492c2fee5d02d630ab26cb1c6dd277f67`, pinning executable
docs/workflows/client-v1-cross-repository-conformance.md:30
- Rebinding this document to the Chat #251 producer makes the timeout description below stale: the actual #251
caveLaunchRpcTimeoutForPlatformreturns30_000 + rpcTimeoutMsfor every platform (40 seconds around the 30-second readiness deadline), not the Windows-specific 85/75-second budget documented at lines 37-38. Please update this paragraph and the matchingRELEASING.mdcopy so the authority documentation matches the producer being pinned.
This binding selects merged Chat #251 producer `c487e29492c2fee5d02d630ab26cb1c6dd277f67`, pinning executable
- Files reviewed: 7/15 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| const unixSupervisorPreparationFixturePath = resolve( | ||
| workspaceRoot, | ||
| 'tests/fixtures/chat-8856ad-unix-supervisor-preparation.sh.br', | ||
| 'tests/fixtures/chat-0e0644-unix-supervisor-preparation.sh.br', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
corepack pnpm@10.34.0 verify