fix(conformance): bind Chat token-profile alignment - #228
Merged
Conversation
Rebind the cross-repository validator and deterministic workflow fixtures to merged Chat #249, including the token-profile and platform-aware launch contracts. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Documentation should qualify token-profile alignment as intended or unverified until protected validation proves the lifecycle.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
This pull request rebinds SDK cross-repository conformance to merged Chat #249 and refreshes related digests, fixtures, tests, and documentation.
Changes:
- Updates producer, workflow, harness, bootstrap, and platform digest pins.
- Refreshes conformance expectations and lock metadata.
- Documents token-profile handling, cleanup, and launch budgets.
File summaries
| File | Description |
|---|---|
tests/conformance-gaps.spec.ts |
Updates producer and fixture digest expectations. |
tests/conformance-contract.spec.ts |
Updates workflow authority assertions. |
scripts/github-conformance-evidence.mjs |
Updates reviewed source pins. |
RELEASING.md |
Updates release and validation notes. |
docs/workflows/client-v1-cross-repository-conformance.md |
Documents the new conformance binding. |
conformance/client-v1-cross-repository-lock.json |
Rebinds the frozen Chat producer. |
Review details
- Files reviewed: 6/9 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+229
to
+234
| The trusted supervisor overwrites the dedicated Windows profile-root binding | ||
| with the operating-system profile registered for the restricted process token. | ||
| The producer validates it independently from the bootstrap-local `USERPROFILE` | ||
| redirect and publishes only the native fixture beneath that profile's | ||
| `.coven/cave`, matching Rust token-profile discovery. A forged caller value | ||
| cannot redirect publication. Fixture deletion follows confirmed RPC closure; |
Comment on lines
+43
to
+48
| The trusted supervisor overwrites the dedicated Windows profile-root binding | ||
| with the operating-system profile registered for the restricted process token. | ||
| The producer validates it independently from the bootstrap-local `USERPROFILE` | ||
| redirect and publishes only the native fixture beneath that profile's | ||
| `.coven/cave`, matching Rust token-profile discovery. A forged caller value | ||
| cannot redirect publication. Fixture deletion follows confirmed RPC closure; |
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
4682a4aa758c8d958f8b87b9976addf14856f76bUSERPROFILE, bounded cleanup, and platform-aware launch budgetsValidation
pnpm verifypassedChat pre-merge CI run
34724946685passed all ten checks, including Windows supervisor behavior and real-authority conformance. Protected cross-repository evidence remains pending until this validator merges and both protected validator variables are rotated.