feat: add opt-in av_log file logging#145
Merged
Merged
Conversation
Add macOS build instructions to CompileGuide.md and create CLAUDE.md with project structure, build steps, and key patterns for context. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Add a Logger singleton (common/logger) that installs a custom av_log callback writing timestamped lines to AppData/OpenConverter/openconverter.log in append mode, while forwarding to the original callback so console output is preserved. Toggle via Settings > Enable Log File in the menu bar; state persisted with QSettings (logging/fileLoggingEnabled). Includes 5 GTest unit tests. Co-Authored-By: Claude Sonnet 4.6 (1M context) <noreply@anthropic.com>
Add Help > About OpenConverter showing version, git commit hash, Qt version, and FFmpeg version in a vertical layout with app logo. On macOS, About and Settings are placed in the application menu. Settings dialog contains the Enable Log File checkbox. CMake now detects git commit hash at configure time via git rev-parse. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Store language, transcoder, enable-log, and last browsed directory in ~/Library/Application Support/OpenConverter/settings.ini. Settings are restored on startup and saved on change (language, transcoder, log toggle) or on exit (last directory). Add a Settings dialog with Reset All Settings button for macOS app menu. SharedData gains a separate lastDirectory field so restoring the saved path doesn't auto-fill page input boxes. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Move About and Settings actions into a programmatic Help menu inserted before Language. On macOS, both actions are moved to the app menu via AboutRole/PreferencesRole and Help disappears. On Windows/Linux, Help menu stays visible at the left of the bar. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
JackLau1222
enabled auto-merge (rebase)
May 18, 2026 14:51
JackLau1222
disabled auto-merge
May 18, 2026 14:51
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.