Preserve and expose mdui:UIInfo during authentication and registratio…#49
Open
kayjoosten wants to merge 1 commit into
Open
Preserve and expose mdui:UIInfo during authentication and registratio…#49kayjoosten wants to merge 1 commit into
kayjoosten wants to merge 1 commit into
Conversation
kayjoosten
force-pushed
the
feature/issue-48-preserve-mdui-uiinfo
branch
from
e990646 to
ab8ae0d
Compare
4 tasks
kayjoosten
force-pushed
the
feature/issue-48-preserve-mdui-uiinfo
branch
from
af428f8 to
a6d0c38
Compare
GSSP apps could not read the mdui:UIInfo data that arrives with proxied AuthnRequests, so they had to fall back to less accurate service naming or duplicate request parsing outside the bundle. Persist the UIInfo chunk in session state for both authentication and registration, then expose it through the public service interfaces that consuming applications already depend on. - add coverage for present and absent UIInfo data in both flows - centralize service-name resolution and formatting for consumers - pin the unreleased stepup-saml-bundle branch needed for integration until the upstream change is released Resolves: #48
kayjoosten
force-pushed
the
feature/issue-48-preserve-mdui-uiinfo
branch
from
f7d9790 to
c6f1b2a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…n (#48)
Reads the mdui:UIInfo extension from incoming AuthnRequests and saves it to session state during both saveAuthenticationRequest and saveRegistrationRequest. Downstream GSSP apps can call getMdui() on StateHandler to retrieve per-language display names.
AuthenticationService::getMdui()/RegistrationService::getMdui(), delegating toStateHandler::getMdui(), so downstream GSSP apps (e.g. gssp-example) can read the mdui data through the public service interfaces they actually consume, not justStateHandlerdirectlyDependency / merge order
composer.jsonpinssurfnet/stepup-saml-bundletodev-feature/issue-48-mdui-chunk as 7.0.99via a VCS repository, withminimum-stability: dev. That branch is Stepup-saml-bundle#137, still open. This must not reach a tagged release as-is — theas 7.0.99alias would hide the dev dependency from downstream constraint solvers.Merge order: saml-bundle#137 → tag a release → swap this PR's composer.json to the tagged version → tag this repo → swap the same pin in Stepup-gssp-example#141.
Test plan
surfnet/stepup-saml-bundledev-branch pin for a tagged release before merge