feat: read mdui:UIInfo from AuthnRequest and forward service name to GSSP#624
Open
kayjoosten wants to merge 2 commits into
Open
feat: read mdui:UIInfo from AuthnRequest and forward service name to GSSP#624kayjoosten wants to merge 2 commits into
kayjoosten wants to merge 2 commits into
Conversation
kayjoosten
force-pushed
the
feature/issue-591-service-name-saml-extension
branch
from
June 29, 2026 11:28
0e6e735 to
c1b3e59
Compare
Gateway could only forward a service name to the GSSP when one was configured in middleware metadata. When EngineBlock supplied the service name via mdui:UIInfo on the incoming AuthnRequest, that information was discarded and the proxied request reached the GSSP without the SP display name. Read mdui:DisplayName values from the incoming AuthnRequest when the feature flag is enabled, store them in proxy state, and forward them on the AuthnRequest sent to the GSSP. Middleware configuration keeps precedence so existing explicit service_name values still win for both SSO and SFO flows. Resolves: #591
kayjoosten
force-pushed
the
feature/issue-591-service-name-saml-extension
branch
from
July 10, 2026 11:09
6ff6b05 to
787a33b
Compare
kayjoosten
force-pushed
the
feature/issue-591-service-name-saml-extension
branch
from
July 14, 2026 11:33
e102674 to
c1546f9
Compare
…ride The isServiceNameFromSamlAuthnRequestEnabled flag wrapped the entire resolveServiceDisplayNames() call in SecondFactorVerificationService, so disabling it also suppressed the middleware-configured service_name override, not just the AuthnRequest-derived fallback it was meant to gate. resolveServiceDisplayNames() now takes an includeAuthnRequestFallback parameter: the middleware override is always considered, while only the AuthnRequest mdui:DisplayName fallback is gated behind the flag.
kayjoosten
force-pushed
the
feature/issue-591-service-name-saml-extension
branch
from
July 14, 2026 11:34
c1546f9 to
9641bcb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Closes #591.
When EngineBlock sends a
mdui:UIInfoextension in the AuthnRequest, Gateway now reads themdui:DisplayNamevalues and forwards the service name in amdui:UIInfoextension on the proxy AuthnRequest sent to the GSSP.enable_service_name_from_saml_authnrequest(disabled by default, configure inparameters.yaml)GatewayBundle) and SFO (SecondFactorOnlyBundle) flowsservice_name(from SP configuration) overridesmdui:DisplayNamefrom the AuthnRequestPriority table
service_namemdui:DisplayNameChanges
UiInfoExtensionHelper— parses and buildsmdui:UIInfoSAML extensionsDisplayName— value object for type-safe lang/value pairs (serializes as plain arrays in session)FeatureConfiguration— named accessor replacing rawboolconstructor argsProxyStateHandler— stores/retrievesDisplayName[]in session stateResponseContext::resolveServiceDisplayNames()— applies priority logic with real SP dataLoginService— parses UIInfo from incoming request viaUiInfoExtensionHelper::parseAndStoreSecondFactorVerificationService— forwards resolved display names to GSSP proxy AuthnRequestparameters.yaml.dist— documents the new flagTest plan
composer test— 258 tests passcomposer phpstan— cleancomposer phpcs— cleancomposer phpmd— cleancomposer phplint— cleanProxyStateHandlerDisplayNameTest,ResponseContextResolveDisplayNamesTest, extendedUiInfoExtensionHelperTest, SFO branch inSecondFactorVerificationServiceTestdevconf/stepup)parameters.yamland verify service name appears in GSSP AuthnRequest with EngineBlock sendingfeature_stepup_send_service_name=true