Add filament unload status messages for frontend feedback - #373
Merged
Merged
Conversation
Right now UNLOAD_FILAMENT works, but from the UI side it's a bit of a black box. The printer does the right thing, but the user has no idea if it's still cutting, retracting, or if it's already finished and waiting for them to pull the filament. This adds status messages so GrumpyScreen (and other frontends) can show the same kind of feedback we already have during loading. The goal is simple: stop users from having to second guess what the printer is doing.
Contributor
|
I don't think agree with the changes here. Maybe a popup saying its done, but the printer should be in constant motion essentially. It isn't like the printer is sitting idle and you question what its waiting for. The console is also not really where many people look for whats happening, especially as its 2 menu's away from unload. SET_DISPLAY_TEXT might be better but the seuqence is so quick i don't know if it has any value Maybe even better, recently the beeper got added. Maybe beep when its done? |
Contributor
Author
|
Alternatively, on the discord, @suchmememanyskill suggested we use instead:
I'll leave it to the devs, so I'll update the PR! |
suchmememanyskill
approved these changes
Oct 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now UNLOAD_FILAMENT works, but from the UI side it's a bit of a black box.
The printer does the right thing, but the user has no idea if it's still cutting, retracting, or if it's already finished and waiting for them to pull the filament.
This adds status messages so GrumpyScreen (and other frontends) can show the same kind of feedback we already have during loading.
The goal is simple: stop users from having to second guess what the printer is doing.
Edit : If this is an approved approach, I'll go ahead and patch grumpy too