Don't publish out of order nightlies - #372
Merged
Merged
Conversation
suchmememanyskill
requested review from
jamesturton
and
a lite review from Copilot
September 30, 2026 20:15
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The unsupported queue concurrency property must be removed.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Updates nightly firmware publishing to serialize releases and skip artifacts from stale commits.
Changes:
- Adds publish-job concurrency control.
- Verifies the build SHA matches
mainbefore upload. - Removes the unsupported
queueconcurrency property required for workflow validation.
| File | Description |
|---|---|
.github/workflows/push.yml |
Adds concurrency and stale-build checks to nightly publishing. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
jamesturton
approved these changes
Sep 30, 2026
jamesturton
left a comment
jamesturton
left a comment
Collaborator
There was a problem hiding this comment.
I'm not very well versed with github ci, but it seems logical to me
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.