Fix/dice typo#1491
Conversation
|
The first two commits are unrelated to this PR. It's good to remove them, so each PR only contains the commits immediately relevant to it; this allows for flexibility regarding the merge order. Your commit descriptions are very close to Conventional Commits: https://www.conventionalcommits.org/en/v1.0.0/ |
SofianElmotiem
force-pushed
the
fix/dice-typo
branch
from
5ba3bbe to
42bf247
Compare
|
Hey Vekhir ,I've rebased the branch so that it now contains only the one commit relevant to this fix. I have updated as well the commit message to follow Conventional Commits format as you suggested ( also learned something new there:) appreciate the pointer! |
Dice is already the correct plural form in English, dices is not standard. Updated all user-visible occurrences in the Dice widget help text and i18n properties file. (#dices) was left unchanged as it is internal code, not UI text. Fixes OpenBoard-org#1438 Signed-off-by: SofianElmotiem <sofianelmotiem@gmail.com>
SofianElmotiem
force-pushed
the
fix/dice-typo
branch
from
42bf247 to
9a815b6
Compare
|
Awesome, thanks for the quick rebase @SofianElmotiem! The commit message is perfect now. And yeah, keeping the internal ID Everything looks good to go from my side! |
abdna94
left a comment
abdna94
left a comment
There was a problem hiding this comment.
Nice catch on the typos in both files! Just noticed in Messages.properties line 13, the key has .de. but the text is in English. I guess we can leave it as English for now since you fixed the main typo, but maybe we should translate it to German later if needed? Either way, the fix looks good!
abdna94
left a comment
abdna94
left a comment
There was a problem hiding this comment.
Looks good to go now. Officially approving this!
3 participants
Fixed a grammar mistake in the Dice widget , "Dices" is not standard English, "Dice" is already the correct plural. Updated the help text and i18n file. Left the internal #dices element ID untouched since that's code, not UI text.
Fixes #1438