Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR closes #437 by reassigning the end-state
massandelementproperties insire.morph.create_from_pertfilebased on inference using the end-stateambertypeproperties. This is needed in order to reverse the mass and element adjustments that are made on pert file writing, allowing for correct application of HMR bysomd2. Without this, HMR is both incorrect (since masses are already non-standard) and asymmetric when perturbing hydrogens are present.develinto this branch before issuing this pull request (e.g. by runninggit pull origin devel): [y]