Skip to content

Minor enhancements to java dubbo server generator - #24660

Merged
wing328 merged 1 commit into
masterfrom
java-dubbo-update
Aug 10, 2026
Merged

Minor enhancements to java dubbo server generator#24660
wing328 merged 1 commit into
masterfrom
java-dubbo-update

Conversation

@wing328

@wing328 wing328 commented Aug 10, 2026

Copy link
Copy Markdown
Member

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

Summary by cubic

Streamlined the JavaDubboServerCodegen by removing unused code, improving logging, and tightening type handling. Also dropped the explicit binarybyte[] mapping to rely on default behavior.

  • Refactors
    • Removed unused methods: getIgnoreFileOutputPath and getPackageForTemplate.
    • Switched to parameterized logging for Dubbo version parsing warnings.
    • Replaced length checks with isEmpty() and cleaned minor redundancies.
    • Updated generics to Schema<?> in collection type declarations.
    • Removed redundant isDataTypeString override.
    • Removed explicit typeMapping for binary (defaults now apply).

Written for commit 77fc7fd. Summary will update on new commits.

Review in cubic

@wing328 wing328 changed the title minor enhancements to java dubbo server generator Minor enhancements to java dubbo server generator Aug 10, 2026
@wing328
wing328 marked this pull request as ready for review August 10, 2026 07:00

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issues found across 1 file

Re-trigger cubic

@wing328
wing328 merged commit 3c785a1 into master Aug 10, 2026
15 checks passed
@wing328
wing328 deleted the java-dubbo-update branch August 10, 2026 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant