Skip to content

[csharp][generichost] Allow property accessor overrides - #24652

Merged
wing328 merged 1 commit into
OpenAPITools:masterfrom
devhl-labs:devhl/allow-property-accessor-overrides
Aug 10, 2026
Merged

[csharp][generichost] Allow property accessor overrides#24652
wing328 merged 1 commit into
OpenAPITools:masterfrom
devhl-labs:devhl/allow-property-accessor-overrides

Conversation

@devhl-labs

@devhl-labs devhl-labs commented Aug 9, 2026

Copy link
Copy Markdown
Contributor

If the api returns poorly named properties or redundant properties, this gives client library authors a way to hide or rename properties. For example, the clash of clans api returns properties MemberList (array) and Members (int). In C#, MemberList isn't a great name, and Members is redundant because the count can be accessed via the list.

PR checklist

  • Read the contribution guidelines.
  • Run the following to build the project and update samples:
    ./mvnw clean package || exit
    ./bin/generate-samples.sh ./bin/configs/*.yaml || exit
    ./bin/utils/export_docs_generators.sh || exit
    
    (For Windows users, please run the script in WSL)
    Commit all changed files.
    This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
    These must match the expectations made by your contribution.
    You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example ./bin/generate-samples.sh bin/configs/java*.
    IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
  • If your PR is targeting a particular programming language, @mention the technical committee members, so they are more likely to review the pull request.

@cubic-dev-ai cubic-dev-ai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All reported issues were addressed across 99 files

Reply with feedback, questions, or to request a fix.

Re-trigger cubic

@wing328
wing328 merged commit 2b209e7 into OpenAPITools:master Aug 10, 2026
87 checks passed
@devhl-labs
devhl-labs deleted the devhl/allow-property-accessor-overrides branch August 10, 2026 03:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants