Reusable PropertyValidationAttributes interface to improve typing in models - #24623
Open
devtobi wants to merge 10 commits into
Open
Reusable PropertyValidationAttributes interface to improve typing in models#24623devtobi wants to merge 10 commits into
devtobi wants to merge 10 commits into
Conversation
devtobi
marked this pull request as ready for review
August 5, 2026 12:45
Contributor
Author
|
Looks like |
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 31 files
Reply with feedback, questions, or to request a fix.
Re-trigger cubic
Contributor
There was a problem hiding this comment.
All reported issues were addressed across 8 files (changes from recent commits).
Tip: Review your code locally with the cubic CLI to iterate faster.
Re-trigger cubic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a central
PropertyValidationAttributesto theruntime.tsand uses it viasatisfiesinside the generated*PropertyValidationAttributesMapobjects. Prior loose typing information of those objects was removed.This enables proper autocompletion for the
*PropertyValidationAttributesMapobjects.The exported
PropertyValidationAttributesinterface can additionally be used by downstream applications (e.g. for implementing validation logic in frontend code)Changes
PropertyValidationAttributesto runtime mustache template*PropertyValidationAttributeMapgeneration to check forsatisfiesusing newPropertyValidationAttributesinstead of defining loose typemodelGenericInterfaces.mustacheto importPropertyValidationAttributeson top of the generated filessatisfiesinstead of[property: string]:Solves #24620
PR checklist
Commit all changed files.
This is important, as CI jobs will verify all generator outputs of your HEAD commit as it would merge with master.
These must match the expectations made by your contribution.
You may regenerate an individual generator by passing the relevant config(s) as an argument to the script, for example
./bin/generate-samples.sh bin/configs/java*.IMPORTANT: Do NOT purge/delete any folders/files (e.g. tests) when regenerating the samples as manually written tests may be removed.
@TiFu (2017/07) @taxpon (2017/07) @sebastianhaas (2017/07) @kenisteward (2017/07) @Vrolijkx (2017/09) @macjohnny (2018/01) @topce (2018/10) @akehir (2019/07) @petejohansonxo (2019/11) @amakhrov (2020/02) @davidgamero (2022/03) @mkusaka (2022/04) @joscha (2024/10) @KannaKim (2026/07)