Add configurable --delay throttle for API requests - #48
Open
Chisomnwa wants to merge 1 commit into
Open
Conversation
|
Noting that, as per our API usage guidelines, only 1 request per second can be made with no |
Collaborator
Author
|
Thanks @jimchamp, that makes sense. I'll update the defaults to 1 second delay and batch size 100. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a configurable
--delayparameter tobackfill_tags.pyto throttle API requests during batch backfill, preventing rate limiting from Open Library.What Changed
backfill_tags.py: Added--delayargument (float, default 0.5s) that controls the pause between API fetch requests during backfill. This lets callers adjust throttle rate per-run instead of editing source code.Motivation
During production backfill planning, @jimchamp warned that unthrottled requests may be blocked by OL's rate limiting. This change adds a safe default delay (0.5s) while keeping it configurable per-run — use
--delay 0.1for faster runs or--delay 1.5when being extra cautious.Related
Stakeholders
@mekarpeles @jimchamp