Local semver

[oocube]

Fixes #676 by introducing semver to local builds and adding the BUILDER environment variable.

[mcarans]

Thanks for looking into this. It's a step in the right direction. See my comments for some requested changes

[mcarans]

Yes it's odd. I have fixed the release so now it's easy to see the versions in the filenames: https://github.com/OoliteProject/oolite/releases/tag/1.93.1-localSemver.11. AppImage is correct which suggests the logic in get_version.sh is ok, but the rest have dirty which is odd. Something must change in the repo during the build for Windows and flatpak only.

flatpak now seems to miss version which I thought I'd already fixed.

[mcarans]

https://github.com/OoliteProject/oolite/releases/tag/1.93.1-localSemver.12 flatpak is now correct (again). Windows still left.

My review is outdated

[mcarans]

Looks better now. It was a Windows line ending issue with git. https://github.com/OoliteProject/oolite/releases/tag/1.93.1-localSemver.15

[phkb]

Is this something to be concerned about?

$ make release
meson setup build/meson_release -Ddebug=false -Dstrip_bin=true -Db_lto=true -Dgithub_repository= --native-file clang.ini --reconfigure 2>/dev/null || meson setup build/meson_release -Ddebug=false -Dstrip_bin=true -Db_lto=true -Dgithub_repository= --native-file clang.ini

ERROR: Unknown option: "github_repository".
Directory already configured.

Just run your build command (e.g. ninja) and Meson will regenerate as necessary.
Run "meson setup --reconfigure" to force Meson to regenerate.

If build failures persist, run "meson setup --wipe" to rebuild from scratch
using the same options as passed when configuring the build.

[mcarans]

Is this something to be concerned about?

$ make release
meson setup build/meson_release -Ddebug=false -Dstrip_bin=true -Db_lto=true -Dgithub_repository= --native-file clang.ini --reconfigure 2>/dev/null || meson setup build/meson_release -Ddebug=false -Dstrip_bin=true -Db_lto=true -Dgithub_repository= --native-file clang.ini

ERROR: Unknown option: "github_repository".
Directory already configured.

Just run your build command (e.g. ninja) and Meson will regenerate as necessary.
Run "meson setup --reconfigure" to force Meson to regenerate.

If build failures persist, run "meson setup --wipe" to rebuild from scratch
using the same options as passed when configuring the build.

I'm guessing meson is caching something from an old build from the message "Directory already configured." Try running make clean. The github_repository option is defined:
https://github.com/OoliteProject/oolite/blob/localSemver/meson.options#L48-L49

[phkb]

I'm getting "Oolite v by unknown" as the title on the Oolite window.

[mcarans]

I'm getting "Oolite v by unknown" as the title on the Oolite window.

The unknown is ok - only CI build of OoliteProject repo will show OoliteProject with everything else showing unknown as per oocube's design to distinguish official builds from all else.

Do you have gitversion installed? ShellScripts/Windows/install_deps.sh installs it.

[mcarans]

I just added a check for gitversion's existence in gitversion.sh.

[phkb]

OK, I ran the install_deps.sh script, and now I get this:

Which I assume is what we want, correct?

[mcarans]

OK, I ran the install_deps.sh script, and now I get this:

Which I assume is what we want, correct?

Yes that's right.

[phkb]

Tested all the NSIS installers, everything looks fine to me.