reject malformed content-length instead of crashing/hanging - #8
Merged
Conversation
a non-numeric Content-Length raised an unhandled ValueError, and a negative one made rfile.read() block indefinitely tying up a worker thread. now both get a clean 400.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a non-numeric Content-Length header raised an unhandled ValueError in do_POST (traceback, dropped connection). a negative one passed the max_body_bytes check and made rfile.read() block indefinitely, tying up a worker thread. both now get a clean 400 before rfile.read() is touched.
added tests for both cases.