cap inbound request body size - #7
Merged
Merged
Conversation
do_POST read Content-Length bytes into memory with no upper bound, so a single request with a huge Content-Length could exhaust memory on a relay meant to sit on the open internet. add max_body_bytes to the config (default 1 MiB) and reject oversized requests with 413 before the body is read.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
do_POST reads Content-Length bytes straight into memory with no upper bound. For a relay meant to sit on the open internet, a single request with a huge Content-Length can exhaust memory before handle_webhook ever sees it.
Adds
max_body_bytesto the config (default 1 MiB) and rejects oversized requests with 413 before the body is read off the socket. Documented in the README config example and limitations section, tests added for config parsing and the actual HTTP behavior.