catch config errors in run command instead of crashing - #6
Merged
Conversation
cmd_check and cmd_send already wrap load_config in try/except and print a clean 'config error: ...' message, but cmd_run called load_config directly. a missing or malformed config file at 'hookrelay run -c ...' time (the normal way this thing gets started, e.g. from systemd) blew up with a raw ConfigError traceback instead of the same clean stderr message the other subcommands give.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
cmd_check and cmd_send already catch ConfigError from load_config and print a clean
config error: ...message to stderr. cmd_run did not, so a missing or malformed config file athookrelay run -c ...(the way this normally gets started, e.g. via systemd) crashed with a raw traceback instead. Fixed to match the other two subcommands, plus tests/test_cli.py which did not exist before.