fix hmac algorithm lookup for names without a hashlib attribute - #4
Merged
Merged
Conversation
hashlib.algorithms_available includes a few names (ripemd160, sm3, sha512_224, md5-sha1) that config.py's validation already accepts but compute() rejected via getattr(hashlib, ...), since those don't exist as module attributes. pass the name straight to hmac.new instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
a few names in hashlib.algorithms_available (ripemd160, sm3, sha512_224, md5-sha1) pass config validation but have no matching hashlib module attribute, so compute() rejected them at request time via getattr(hashlib, ...). switched to passing the algorithm name straight to hmac.new as digestmod, which handles all of them. added a regression test.