Repository navigation
Preserve list identities and protect managed imports for 0.42.9 - #10
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
External lists can import television shows as movies because provider media types are discarded or passed through as
tv, which the episode importer does not recognize. AniList also treated theatrical films as television. Preserve provider identity and year and return the internalmovie/seriestypes before new catalog rows are created.mediatype/release_year, use grouped movie/show context, and reject contradictory or untyped entries.first_air_date; retain V3 untyped movie compatibility without guessing name-only items.The external-list guide explains these contracts, existing-row repair limits and comparisons with Kometa and HomeScreenCompanion. These consumers distinguish identity during conversion or select existing items; ignoring type cannot be copied safely into a new STRM importer.
Generic catalog upserts could also undo a repaired series identity: an incoming movie DTO replaced media type, year and TMDB ID while a missing incoming path preserved the existing series path. Atomically reject movie/episodic conflicts for managed STRM rows and owned-media retirements. Bulk sync skips only conflicting rows, emits warnings, and reports accepted/total counts; same-family anime/series updates retain the established managed destination type. Sparse refreshes preserve known year/TMDB values.
Validation: the synthetic provider audit compiled and reproduced 19 failing cases before the parser fixes. The final 0.42.9 pinned-Emby-ABI build passed all 165 tests and published the DLL; repository checks and whitespace checks pass. Tests include 31 dedicated provider identity cases plus eight real SQLite persistence cases covering single/bulk rejection, preserved blocks/retries/retirement, partial bulk progress, sparse metadata, compatible anime/series updates and unpublished/separate-source intent. No credentialed live-provider requests or playback acceptance tests were performed.
Existing catalog rows are not automatically reclassified or moved. The candidate assembly/plugin metadata is bumped to 0.42.9.0. This PR contains no automatic database migration, production deployment or restart. Existing misclassified rows require a separate backed-up destination and identity repair that preserves memberships, blocks, retry history and owned media.