FUND-2559 ZRC: improve security around query parameters on subjects#183
Open
heuvea wants to merge 8 commits into
Open
FUND-2559 ZRC: improve security around query parameters on subjects#183heuvea wants to merge 8 commits into
heuvea wants to merge 8 commits into
Conversation
heuvea
added
Bug
![aikido-pr-checks[bot]](https://avatars.githubusercontent.com/in/898896?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves request parameter hardening across ZGW API components by adding reusable validation filters for unknown query/body parameters and applying them to list/search endpoints. It also extends ZRC audit logging for privacy-sensitive zaak queries.
Changes:
- Adds common query/body parameter validation filters.
- Registers and applies validation filters across Zaken, Documenten, Catalogi, Besluiten, Autorisaties, and Referentielijsten endpoints.
- Extends audit trail logging for additional sensitive Zaken filters.
Reviewed changes
Copilot reviewed 62 out of 62 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
src/OneGround.ZGW.Common.Web/Validations/ValidateQueryParametersFilter.cs |
Adds generic query parameter allow-list validation. |
src/OneGround.ZGW.Common.Web/Validations/ValidateBodyParametersFilter.cs |
Adds generic JSON body property allow-list validation. |
src/OneGround.ZGW.Zaken.Web/Startup.cs |
Registers Zaken validation filters. |
src/OneGround.ZGW.Zaken.Web/Extensions/QueryAndSearchParameterValidationsExtensions.cs |
Adds Zaken filter registrations. |
src/OneGround.ZGW.Zaken.Web/Handlers/v1/5/GetAllZakenQueryHandler.cs |
Expands audit logging for sensitive zaak filters. |
src/OneGround.ZGW.Zaken.Web/Controllers/v1/ZakenController.cs |
Applies Zaken query/search validation. |
src/OneGround.ZGW.Zaken.Web/Controllers/v1/ZaakStatussenController.cs |
Applies query validation. |
src/OneGround.ZGW.Zaken.Web/Controllers/v1/ZaakResultatenController.cs |
Applies query validation. |
src/OneGround.ZGW.Zaken.Web/Controllers/v1/ZaakObjectenController.cs |
Applies query validation. |
src/OneGround.ZGW.Zaken.Web/Controllers/v1/ZaakInformatieObjectenController.cs |
Applies query validation. |
src/OneGround.ZGW.Zaken.Web/Controllers/v1/KlantContactenController.cs |
Applies query validation. |
src/OneGround.ZGW.Zaken.Web/Controllers/v1/2/ZaakObjectenController.cs |
Applies query validation. |
src/OneGround.ZGW.Zaken.Web/Controllers/v1/5/ZakenController.cs |
Applies v1.5 query/search validation. |
src/OneGround.ZGW.Zaken.Web/Controllers/v1/5/ZaakVerzoekenController.cs |
Applies query validation. |
src/OneGround.ZGW.Zaken.Web/Controllers/v1/5/ZaakStatussenController.cs |
Applies query validation. |
src/OneGround.ZGW.Zaken.Web/Controllers/v1/5/ZaakRollenController.cs |
Applies query validation. |
src/OneGround.ZGW.Zaken.Web/Controllers/v1/5/ZaakObjectenController.cs |
Applies query validation. |
src/OneGround.ZGW.Zaken.Web/Controllers/v1/5/ZaakInformatieObjectenController.cs |
Applies query validation. |
src/OneGround.ZGW.Zaken.Web/Controllers/v1/5/ZaakContactMomentenController.cs |
Applies query validation. |
src/OneGround.ZGW.Referentielijsten.Web/Startup.cs |
Registers Referentielijsten validation filters. |
src/OneGround.ZGW.Referentielijsten.Web/Extensions/QueryParameterValidationExtensions.cs |
Adds Referentielijsten filter registrations. |
src/OneGround.ZGW.Referentielijsten.Web/Controllers/ResultatenController.cs |
Applies query validation. |
src/OneGround.ZGW.Referentielijsten.Web/Controllers/ProcesTypenController.cs |
Applies query validation. |
src/OneGround.ZGW.Documenten.Web/Startup.cs |
Registers Documenten validation filters. |
src/OneGround.ZGW.Documenten.Web/Extensions/QueryParameterValidationExtensions.cs |
Adds Documenten filter registrations. |
src/OneGround.ZGW.Documenten.Web/Controllers/v1/EnkelvoudigInformatieObjectenController.cs |
Applies query validation. |
src/OneGround.ZGW.Documenten.Web/Controllers/v1/GebruiksRechtenController.cs |
Applies query validation. |
src/OneGround.ZGW.Documenten.Web/Controllers/v1/ObjectInformatieObjectenController.cs |
Applies query validation. |
src/OneGround.ZGW.Documenten.Web/Controllers/v1/1/EnkelvoudigInformatieObjectenController.cs |
Applies query validation. |
src/OneGround.ZGW.Documenten.Web/Controllers/v1/5/EnkelvoudigInformatieObjectenController.cs |
Applies query validation. |
src/OneGround.ZGW.Documenten.Web/Controllers/v1/5/GebruiksRechtenController.cs |
Applies query validation. |
src/OneGround.ZGW.Documenten.Web/Controllers/v1/5/ObjectInformatieObjectenController.cs |
Applies query validation. |
src/OneGround.ZGW.Documenten.Web/Controllers/v1/5/VerzendingenController.cs |
Applies query validation. |
src/OneGround.ZGW.Catalogi.Web/Startup.cs |
Registers Catalogi validation filters. |
src/OneGround.ZGW.Catalogi.Web/Extensions/QueryParameterValidationExtensions.cs |
Adds Catalogi filter registrations. |
src/OneGround.ZGW.Catalogi.Web/Controllers/v1/CatalogusController.cs |
Applies query validation. |
src/OneGround.ZGW.Catalogi.Web/Controllers/v1/BesluitTypeController.cs |
Applies query validation. |
src/OneGround.ZGW.Catalogi.Web/Controllers/v1/EigenschapController.cs |
Applies query validation. |
src/OneGround.ZGW.Catalogi.Web/Controllers/v1/InformatieObjectTypeController.cs |
Applies query validation. |
src/OneGround.ZGW.Catalogi.Web/Controllers/v1/ResultaatTypeController.cs |
Applies query validation. |
src/OneGround.ZGW.Catalogi.Web/Controllers/v1/RolTypeController.cs |
Applies query validation. |
src/OneGround.ZGW.Catalogi.Web/Controllers/v1/StatusTypeController.cs |
Applies query validation. |
src/OneGround.ZGW.Catalogi.Web/Controllers/v1/ZaakTypeController.cs |
Applies query validation. |
src/OneGround.ZGW.Catalogi.Web/Controllers/v1/ZaakTypeInformatieObjectTypeController.cs |
Applies query validation. |
src/OneGround.ZGW.Catalogi.Web/Controllers/v1/2/InformatieObjectTypeController.cs |
Applies query validation. |
src/OneGround.ZGW.Catalogi.Web/Controllers/v1/3/CatalogusController.cs |
Applies query validation. |
src/OneGround.ZGW.Catalogi.Web/Controllers/v1/3/BesluitTypeController.cs |
Applies query validation. |
src/OneGround.ZGW.Catalogi.Web/Controllers/v1/3/EigenschapController.cs |
Applies query validation. |
src/OneGround.ZGW.Catalogi.Web/Controllers/v1/3/InformatieObjectTypeController.cs |
Applies query validation. |
src/OneGround.ZGW.Catalogi.Web/Controllers/v1/3/ResultaatTypeController.cs |
Applies query validation. |
src/OneGround.ZGW.Catalogi.Web/Controllers/v1/3/RolTypeController.cs |
Applies query validation. |
src/OneGround.ZGW.Catalogi.Web/Controllers/v1/3/StatusTypeController.cs |
Applies query validation. |
src/OneGround.ZGW.Catalogi.Web/Controllers/v1/3/ZaakObjectTypeController.cs |
Applies query validation. |
src/OneGround.ZGW.Catalogi.Web/Controllers/v1/3/ZaakTypeController.cs |
Applies query validation. |
src/OneGround.ZGW.Catalogi.Web/Controllers/v1/3/ZaakTypeInformatieObjectTypeController.cs |
Applies query validation. |
src/OneGround.ZGW.Besluiten.Web/Startup.cs |
Registers Besluiten validation filters. |
src/OneGround.ZGW.Besluiten.Web/Extensions/QueryParameterValidationExtensions.cs |
Adds Besluiten filter registrations. |
src/OneGround.ZGW.Besluiten.Web/Controllers/v1/BesluitenController.cs |
Applies query validation. |
src/OneGround.ZGW.Besluiten.Web/Controllers/v1/BesluitInformatieObjectenController.cs |
Applies query validation. |
src/OneGround.ZGW.Autorisaties.Web/Startup.cs |
Registers Autorisaties validation filters. |
src/OneGround.ZGW.Autorisaties.Web/Extensions/QueryParameterValidationExtensions.cs |
Adds Autorisaties filter registration. |
src/OneGround.ZGW.Autorisaties.Web/Controllers/v1/ApplicatiesController.cs |
Applies query validation. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
![github-code-quality[bot]](https://avatars.githubusercontent.com/u/9919?s=60&v=4){kind=small}
…ect' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
…ect' Co-authored-by: Copilot Autofix powered by AI <223894421+github-code-quality[bot]@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ome audits
Pull Request
Description
Type of Change
Related Issues
Testing
Checklist