PR12: Enterprise IAM/RBAC end-to-end validation and hardening - #1
Merged
Merged
Conversation
…ole checks /jobs/evaluate was a complete stub -- unconditionally returned "job approved" regardless of gpus requested, partition, or caller roles, never calling the already-existing (already unit-tested via QuotaService) validate_gpu_access/validate_partition_access checks. Now actually calls them, same order QuotaService.evaluate already used. /quota/check hardcoded roles=["gpu_user"] for every single caller regardless of who they actually were -- meaning any authenticated user always passed the GPU/DGX role check. Now uses the caller's real roles (QuotaCheck gains a roles field, default [] so an unmodified caller sees the same behavior gpu.py/policies.py already give an empty roles list). Also adds QuotaCheck.partition (default "cpu") -- QuotaService.evaluate already read request.partition, but the field never existed on this model at all, a pre-existing gap the test suite had previously worked around by mocking QuotaService.evaluate entirely rather than exercising the real path. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan