fix(control-center): show full line breakdown on Projects tab KPI row - #80
Merged
Merged
Conversation
Replace the 4-card KPI row (repositories/code lines/largest repo/ categories) with the same 6-metric breakdown the internal static ecosystem report already shows: files, documentation, code lines, comment lines, blank lines, total lines -- code lines stays the primary/highlighted metric and still drives ranking (donut, bars, largest-repo ordering, default sort), matching the earlier decision that code-only LOC is the more style-independent metric; the other lines are shown transparently alongside it instead of hidden. "documentation" uses the same narrow definition the internal report uses (Markdown-only, not every docs-type language) so the number matches across both surfaces. Fixes a test fixture gap surfaced by this change: PublicEcosystemPage's mock ReportData.grand was missing `files`, unnoticed until the tab started reading it directly. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014sNhqTgqynXCnKpmt7KbgK
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Follow-up to #79. The Projects tab's KPI row now shows the same 6-metric breakdown the internal static ecosystem report (
scripts/generate_report.py) already shows at the top level: files, documentation, code lines, comment lines, blank lines, total lines — instead of the previous 4 cards (repositories / code lines / largest repo / categories).Code lines stays the primary/highlighted metric and keeps driving the ranking (donut chart, project bars, largest-repo ordering, default table sort) — per the earlier discussion in this thread: code-only LOC is the more style-independent metric across repos with different comment/blank conventions, so it shouldn't be replaced as the ranking basis. The other lines are now shown transparently alongside it rather than hidden, and the
totalcolumn added in #79 stays as a secondary column in the breakdown table.documentationuses the same narrow definition as the internal report (Markdown-only, not every docs-type language) so the number is identical across both surfaces.Also fixed
PublicEcosystemPage.test.tsx's mockReportData.grandwas missingfiles(masked by anas anycast) — harmless until this change madeProjectsTabreadgrand.filesdirectly, which then crashed under test. Added it to match the realReportDatashape.Testing
npx tsc --noEmit— cleannpx vitest run— 678/678 passingnpm run build— succeeds🤖 Generated with Claude Code
https://claude.ai/code/session_014sNhqTgqynXCnKpmt7KbgK