Sorry, this isn't an issue, more of a question.
On this line:
|
const status = type << (4 + channel); |
Can you explain adding
channel here? Doesn't it shift the
type bits too far?
According to the Linnstrument midi docs, CC should be 1011cccc where c is the channel. To me, this should be const status = type << 4 | channel);, where the << shifts 4 spaces left and | channel flips the appropriate bits to set the channel.
But... it seems your code works.
What do you think?
Sorry, this isn't an issue, more of a question.
On this line:
loopstrument/src/Bitwig.ts
Line 39 in a65e668
Can you explain adding
channelhere? Doesn't it shift thetypebits too far?According to the Linnstrument midi docs, CC should be
1011ccccwherecis the channel. To me, this should beconst status = type << 4 | channel);, where the<<shifts 4 spaces left and| channelflips the appropriate bits to set the channel.But... it seems your code works.
What do you think?