Skip to content

Add remaining Guava BloomFilter operations and stream compatibility - #28

Merged
OldPanda merged 1 commit into
masterfrom
fix/guava-remaining-compatibility
Oct 8, 2026
Merged

OldPanda merged 1 commit into
masterfrom
fix/guava-remaining-compatibility

Conversation

@OldPanda

@OldPanda OldPanda commented Oct 8, 2026

Copy link
Copy Markdown
Owner

Summary

Loaded Guava BloomFilters can now be copied, merged, compared, and inspected in Python using behavior consistent with Guava 33.7.2. Binary stream APIs also allow reading and writing the compact serialization format directly.

Changes

  • Add copy, is_compatible, and put_all, preserving copy independence and rejecting incompatible merges before mutation.
  • Add expected_fpp and approximate_element_count, including Guava-compatible rounding and saturated-filter handling.
  • Add filter equality and serialized_size.
  • Add read_from and write_to, supporting partial reads/writes without closing caller-owned streams.
  • Validate allocation limits before reading stream payloads and reject negative serialized word counts.
  • Document compact-format compatibility, custom-funnel equality, and concurrency limitations.

Testing

  • Compare statistics, copy/merge behavior, serialized bytes, and membership results against Guava for both hash strategies.
  • Cover stream boundaries, truncated data, allocation limits, and I/O failures.
  • Existing CI jobs automatically run the new tests.
  • 38 tests and 110 subtests passed.
  • Package coverage: 100% — 352 statements, zero missed.
  • Formatting, strict typing, and security checks passed.

Limitations

Java object serialization remains unsupported; compatibility targets Guava’s compact writeTo / readFrom format. Shared filters require external synchronization for concurrent access.

@OldPanda

OldPanda commented Oct 8, 2026

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-08T07:10:11.958623Z 39be5cc Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@codecov

codecov Bot commented Oct 8, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (e504de4) to head (39be5cc).

Additional details and impacted files
@@            Coverage Diff            @@
##            master       #28   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          291       352   +61     
=========================================
+ Hits           291       352   +61     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Keep it up!

Reviewed commit: 39be5cc43c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@OldPanda
OldPanda merged commit 68163e9 into master Oct 8, 2026
21 checks passed
@OldPanda
OldPanda deleted the fix/guava-remaining-compatibility branch October 8, 2026 07:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant