Repository navigation
Add remaining Guava BloomFilter operations and stream compatibility - #28
Conversation
|
@codex review |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #28 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 4 4
Lines 291 352 +61
=========================================
+ Hits 291 352 +61 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Codex Review: Didn't find any major issues. Keep it up! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Summary
Loaded Guava BloomFilters can now be copied, merged, compared, and inspected in Python using behavior consistent with Guava 33.7.2. Binary stream APIs also allow reading and writing the compact serialization format directly.
Changes
copy,is_compatible, andput_all, preserving copy independence and rejecting incompatible merges before mutation.expected_fppandapproximate_element_count, including Guava-compatible rounding and saturated-filter handling.serialized_size.read_fromandwrite_to, supporting partial reads/writes without closing caller-owned streams.Testing
Limitations
Java object serialization remains unsupported; compatibility targets Guava’s compact
writeTo/readFromformat. Shared filters require external synchronization for concurrent access.