Repository navigation
Fix Guava BloomFilter interoperability and add cross-language tests - #26
Conversation
|
@codex review the pr |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #26 +/- ##
===========================================
+ Coverage 96.15% 100.00% +3.84%
===========================================
Files 3 4 +1
Lines 208 279 +71
===========================================
+ Hits 200 279 +79
+ Misses 8 0 -8 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 17b476888b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a7fa23761d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6f0ae9d5a5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. What shall we delve into next? Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
1 participant
Summary
Improve compatibility with Bloom filters serialized by Java Guava and add bidirectional integration tests against Guava 33.7.2.
Changes
MURMUR128_MITZ_32to match Java’s signed 32-bit overflow behavior.INTEGER_FUNNELLONG_FUNNELUTF8_STRING_FUNNELBYTE_ARRAY_FUNNELLEGACY_FUNNEL.mightContainbehavior across more than 5,000 deterministic probesCompatibility
Existing callers that do not specify a funnel continue using the historical
LEGACY_FUNNELbehavior.For reliable Guava interoperability, callers should explicitly select the same funnel used by Java.
Testing
Security
The CI integration job downloads a pinned Guava JAR over HTTPS and verifies its SHA-256 checksum before compiling or executing it.
No new runtime network or subprocess behavior is added to the library.