Skip to content

fix: resolve new dependency advisories failing yarn audit - #648

Open
douglance wants to merge 2 commits into
mainfrom
dl/fix-yarn-audit
Open

fix: resolve new dependency advisories failing yarn audit#648
douglance wants to merge 2 commits into
mainfrom
dl/fix-yarn-audit

Conversation

@douglance

Copy link
Copy Markdown
Contributor

Summary

The Audit job has been red on every PR (including dependabot's) since a wave of advisories published ~2026-07-20. All of them have patched versions inside the currently-used ranges, so this bumps the existing resolutions pins instead of allowlisting:

Package Pin Advisories
axios (direct devDep) ^1.17.0^1.18.0 GHSA-gcfj-64vw-6mp9 + 9 others patched in 1.18.0
**/sol2uml/axios 0.32.0 → 0.33.0 same set, 0.x line
**/immutable 4.3.8 → 4.3.9 GHSA-v56q-mh7h-f735, GHSA-xvcm-6775-5m9r
**/fast-uri 3.1.2 → 3.1.4 GHSA-v2hh-gcrm-f6hx, GHSA-4c8g-83qw-93j6
**/hardhat/adm-zip (new) 0.6.0 GHSA-xcpc-8h2w-3j85
**/eslint/js-yaml, **/eslint/@eslint/eslintrc/js-yaml 3.14.2 → 3.15.0 GHSA-52cp-r559-cp3m
**/mocha/js-yaml 4.1.1 → 4.3.0 GHSA-52cp-r559-cp3m
**/brace-expansion 1.1.12 → 1.1.16 GHSA-3jxr-9vmj-r5cp
**/mocha/minimatch/brace-expansion, **/convert-svg-core/glob/minimatch/brace-expansion 2.0.2 → 2.1.2 GHSA-3jxr-9vmj-r5cp

The bumped pins also cover two allowlisted advisories that previously had no compatible patch (GHSA-f886-m6hf-6m8v brace-expansion, GHSA-h67p-54hq-rp68 js-yaml) — audit-ci itself now suggests un-allowlisting them, so their entries are removed from audit-ci.jsonc.

Verification

  • yarn audit:ci locally: Passed yarn security audit (was 11 failing findings)
  • All bumps are patch/minor updates of dev-only or transitive pins; the CI matrix (unit + integration against testnode) exercises hardhat/mocha/eslint paths

Unblocks the Audit check on #647 and every other open PR.

A wave of advisories published around 2026-07-20 pushed the audit job
red on every PR. All have in-range patched versions, so bump the
existing resolutions rather than allowlisting:

- axios ^1.18.0 (direct devDep) and sol2uml/axios 0.33.0
- immutable 4.3.9, fast-uri 3.1.4
- adm-zip 0.6.0 (new resolution; hardhat pulls a vulnerable <0.6.0)
- js-yaml 3.15.0 (eslint) / 4.3.0 (mocha)
- brace-expansion 1.1.16 / 2.1.2

The bumped pins also cover two previously-unfixable allowlisted
advisories (GHSA-f886-m6hf-6m8v, GHSA-h67p-54hq-rp68), so drop them
from audit-ci.jsonc.
OffchainLabs/arbitrum-testnode was renamed to OffchainLabs/arbitrum-litro.
GitHub Actions does not follow repo renames when resolving 'uses:'
references, so jobs using this action fail at setup with "Unable to
resolve action. Repository not found". The pinned tag exists on the
renamed repo; only the action reference needs updating.
@douglance

Copy link
Copy Markdown
Contributor Author

Cherry-picked #647's one-line testnode→litro rename fix so the integration matrix can actually run here (main's workflow still points at the renamed repo, which fails at job setup). Content-identical to #647, merges cleanly in either order. Expected result: this PR fully green; #647 red only on Audit until this merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants