Fixing an issue in the run a runbook step when a fixed version of a package is used#1682
Open
BobJWalker wants to merge 1 commit intoOctopusDeploy:masterfrom
Open
Fixing an issue in the run a runbook step when a fixed version of a package is used#1682BobJWalker wants to merge 1 commit intoOctopusDeploy:masterfrom
BobJWalker wants to merge 1 commit intoOctopusDeploy:masterfrom
Conversation
|
Start Hyponome locally |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
This PR fixed Issue 1680 - when a fixed version of a package is used in a runbook it causes a 400 bad request when attempting to run a runbook.
This happens when:
The reason this happens is because the step was always attempting to find the latest version of the package.
Results
This fixes the issue:
Before
When the package version was fixed:
It would still attempt to use the latest version:

After
After this update that error no longer occurs:
Also verified that this works when not specifying a package version (regression testing)

Pre-requisites
Idshould be a GUID that is not00000000-0000-0000-0000-000000000000Idproperty (updating theIdwill break the Library sync functionality in Octopus).Versionshould be incremented, otherwise the integration with Octopus won't update the step template correctly$LastModifiedByfield must be present, and (optionally) updated with the correct authorCategoryhas been created:{categoryname}.pngmust be present under thestep-templates/logosfolderswitchin thehumanizefunction ingulpfile.babel.jsmust have acasestatement corresponding to itFixes #1680