Skip to content

Page the REST pulls list by hand instead of --paginate #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Octember merged 1 commit into from
Sep 7, 2026
Merged

Page the REST pulls list by hand instead of --paginate #72

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 19 additions & 6 deletions src/sweep/prs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,15 +29,29 @@ const PR_LIST_LIMIT = 500
const ListedPr = Pr.omit({ baseRefOid: true })
const RestPull = z.object({ number: z.number(), base: z.object({ sha: z.string() }) })

const REST_PAGE = 100

// `gh pr list --json` on Ubuntu's 2.45 gh has headRefOid but not baseRefOid — unknown field → empty
// stdout, which the sweep used to log as "auth/network down". Pull base SHAs from REST instead.
// Page by hand, NOT `--paginate`: gh follows GitHub's Link header verbatim, and that header names
// api.github.com — so behind an exe.dev GH_HOST proxy, page 2 escapes the proxy, goes out unauthenticated,
// and 404s the whole call. Only a repo with >100 open PRs ever has a page 2 (bevyl, 5 days of dead sweeps).
function pullBaseOids(slug: string): Map<number, string> | null {
const r = exec('gh', ['api', `repos/${slug}/pulls?state=open&per_page=100`, '--paginate'])
if (!r.ok) {
return null
const bases = new Map<number, string>()
for (let page = 1; ; page++) {
const r = exec('gh', ['api', `repos/${slug}/pulls?state=open&per_page=${REST_PAGE}&page=${page}`])
if (!r.ok) {
log(`gh api pulls failed — aborting sweep: ${r.combined.trim().split('\n')[0] ?? 'unknown error'}`)
return null
}
const pulls = z.array(RestPull).parse(JSON.parse(r.stdout))
for (const p of pulls) {
bases.set(p.number, p.base.sha)
}
if (pulls.length < REST_PAGE) {
return bases
}
}
const pulls = z.array(RestPull).parse(JSON.parse(r.stdout))
return new Map(pulls.map((p) => [p.number, p.base.sha]))
}

export function listPrs(cfg: Config): Pr[] | null {
Expand All @@ -62,7 +76,6 @@ export function listPrs(cfg: Config): Pr[] | null {
const listed = z.array(ListedPr).parse(JSON.parse(r.stdout))
const bases = pullBaseOids(cfg.slug)
if (bases === null) {
log('gh api pulls failed (auth/network down?) — aborting sweep')
return null
}
const out: Pr[] = []
Expand Down