fix(accounts): integrate credential and file recovery lifecycles - #470
Open
veryCrunchy wants to merge 579 commits into
Open
fix(accounts): integrate credential and file recovery lifecycles#470veryCrunchy wants to merge 579 commits into
veryCrunchy wants to merge 579 commits into
Conversation
obiente-cloud
Bot
temporarily deployed
to
Obiente Preview / PR #470 / NC Native
September 14, 2026 05:54
Destroyed
Obiente previewNC Native · Obiente updates this comment as the preview changes. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Account removal, credential changes, queued work, and retained Android file access now share account ownership and recoverable cleanup boundaries. A delayed operation cannot reopen a removed account's private state, take a new folder permission for a cancelled selection, or use another account's credentials.
This integrates #436, #438, #439, #445, #446, #447, #455, #456, and #457 against main, preserving their commits and incorporating the fixes found during combined review.
Behavior
Advances #172 and #52.
Validation
These are source and deterministic validation results, not a release or a claim of complete multi-account product support. This combined revision has not been validated on a physical Android device or against a live Nextcloud server. The repository emulator launcher requires Linux KVM and could not start on the Windows host, so emulator smoke and Android Keystore instrumentation remain unverified. Linux/macOS platform integration, native credential-store behavior, Android WorkManager process recovery, and external document-client lifecycle behavior still require the relevant platform evidence; Windows-hosted unit tests do not establish those outcomes.