Repository navigation
fix(build): make clean reactor test compilation work - #154
Merged
Merged
Conversation
Create the core multi-release JAR during process-classes so downstream JPMS adapter modules can resolve owasp.encoder during pre-package reactor phases. Add a clean test-compile CI check. Fixes OWASP#140
jmanico
reviewed
Sep 26, 2026
jmanico
left a comment
Member
There was a problem hiding this comment.
Sol review: no blocking findings at 3b84438. The issue reproduces from a clean pre-package reactor because adapters need the core multi-release JAR for Java 9 module resolution; this patch creates it after bnd writes the manifest and before adapters compile. On JDK 17, full-reactor clean test-compile, clean test, verify, and install -DskipTests all passed. The core JAR entry inventory matches the baseline build exactly; its manifest retains Multi-Release and OSGi metadata, and META-INF/versions/9/module-info.class is present. Worktree clean; whitespace diff check passed. Awaiting integration with latest main and Astra final review.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A clean reactor
test-compileortestcould not resolveowasp.encoderwhen the adapter modules compiled their Java 9 descriptors: core's multi-release JAR was only created atpackage.Create that JAR during
process-classes, after bnd generates its manifest, and disable the redundantdefault-jarlifecycle execution. Remove unsupported JAR-pluginskipsettings. CI now explicitly runsclean test-compilebefore the existing installation and Jakarta integration build.Validation on JDK 17 with an isolated Maven cache:
clean test-compile,clean test, andclean verifypassed.install -DskipTestspassed for all five modules after verification.reactor-jar; the resulting core JAR retainsMulti-Release: true, OSGi metadata, and the Java 9 descriptor. Existing module-path and OSGi integration tests passed.Current main was merged without rewriting contributor commits. Hosted CI and the required Sol review must pass for the current head before merge.
Fixes #140.