Parity review needed - R NNS 9012ec236283e6584323cd482b9f0141b8b32a8b#70
Closed
OVVO-Financial wants to merge 1 commit into
Closed
Parity review needed - R NNS 9012ec236283e6584323cd482b9f0141b8b32a8b#70OVVO-Financial wants to merge 1 commit into
OVVO-Financial wants to merge 1 commit into
Conversation
OVVO-Financial
deleted the
parity-review-9012ec236283e6584323cd482b9f0141b8b32a8b
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Live-R parity for the changed R API needs human review.
Cause: Live R parity diverged: public Python behavior differs from live R at the recorded commit.
R commit:
9012ec236283e6584323cd482b9f0141b8b32a8bR version:
13.1Reports committed on this branch:
sync/last_r_api_inspection.mdsync/last_r_api_plan.jsonsync/last_live_r_parity_report.mdCurrent method (automated fixing agent deferred): a maintainer
reproduces the divergence against live R and applies a reviewed
parity fix to
src/nns/**. Record the function, arguments, R output,Python output, first divergent intermediate, and affected files.
Native differences route through NNS-core. A DESCRIPTION/version or
behavior change is a separate, reviewed cache regeneration. Do not
edit
tests/_r_cache.jsonto force a pass.