Skip to content

handle MSVC warnings #148

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jmckenna wants to merge 1 commit into
base: master
Choose a base branch
from
Open

handle MSVC warnings #148

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion libgeotiff/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
# Author: Mateusz Loskot <mateusz@loskot.net>
#
###############################################################################
CMAKE_MINIMUM_REQUIRED(VERSION 3.13)
CMAKE_MINIMUM_REQUIRED(VERSION 3.16...3.29)

@hobu hobu Aug 31, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure this CMake bump is aligned with PROJ and GDAL. There's no reason for the maximum version though, is there?

@rouault rouault Aug 31, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hobu FYI the maximum version in the range is the maximum version of the CMake policies to enable, not the maximum version of CMake you can use. So here this means that all policies added between 3.16 to 3.29 are set to NEW


PROJECT(GeoTIFF)

Expand Down
5 changes: 4 additions & 1 deletion libgeotiff/geo_normalize.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,10 @@
#endif
#endif

CPL_INLINE static void CPL_IGNORE_RET_VAL_INT(CPL_UNUSED int unused) {}
CPL_INLINE static void CPL_IGNORE_RET_VAL_INT(CPL_UNUSED int unused)
{
(void)unused;
}

/************************************************************************/
/* GTIFKeyGetSSHORT() */
Expand Down
Loading