Conversation
`check_gui` can return None and there is no guard before call `gui_process.wait()`. As this state can be reached only on a broken setup, it makes sense to just warn user and exit. Co-authored with Claude Opus 5
marisn
changed the title
echoix
previously approved these changes
Aug 24, 2026
echoix
left a comment
echoix
left a comment
Member
There was a problem hiding this comment.
I don't see nothing wrong with this
petrasovaa
requested review from
wenzeslaus
and removed request for
petrasovaa
August 24, 2026 14:15
wenzeslaus
requested changes
Aug 25, 2026
wenzeslaus
left a comment
wenzeslaus
left a comment
Member
There was a problem hiding this comment.
Needless to say, this code would need much more work to make it smoother, but this is good for what it does. Definitively a case we want to handle (we already handle the no TTY/no interactive IO case for both GUI and --exec, so this fits right in).
Besides going back to the simple check, possibly also update lib/init/grass.md (around line 118?), which describes the text-mode as unconditional fallback. So perhaps add a condition ("...if [interactive] term... is available...") or describe when GRASS exits with an error.
Remove unnecessary GUI type check Co-authored-by: Vaclav Petras <wenzeslaus@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
check_guican return None and there is no guard before callgui_process.wait().As this state can be reached only on a broken setup, it makes sense to just warn user and exit.
Discovered by a wrong Docker usage – not common, but also possible to reach.
Co-authored with Claude Opus 5
Test:
env -u DISPLAY grass /path/to/mapset < /dev/null