Skip to content

configure: update to and require use of autoconf 2.72 - #6533

Merged
nilason merged 1 commit into
OSGeo:mainfrom
nilason:update_autoconf_272
Oct 29, 2025
Merged

nilason merged 1 commit into
OSGeo:mainfrom
nilason:update_autoconf_272

Conversation

@nilason

@nilason nilason commented Oct 20, 2025

Copy link
Copy Markdown
Contributor

Follow up to the de facto update with commit: ec42cfa.

Run with autoreconf -vfi.

(What version we use is only of importance for developers updating the configure scripts, not users/builders which use the generated configure script anyway.)

Follow up to the de facto update with commit: ec42cfa
@nilason nilason added this to the 8.5.0 milestone Oct 20, 2025
@marisn

marisn commented Oct 21, 2025

Copy link
Copy Markdown
Contributor

Do we have to bump up autoconf requirement? The fact that configure was generated with a more recent version doesn't mean an older version can not be used.

@nilason

nilason commented Oct 21, 2025

Copy link
Copy Markdown
Contributor Author

Do we have to bump up autoconf requirement? The fact that configure was generated with a more recent version doesn't mean an older version can not be used.

We don’t have to, but using different versions lead to unrelated changes (cluttered history). The version is only of importance for us devs, as it now stands, so whichever is more convenient.

@ninsbl

ninsbl commented Oct 21, 2025

Copy link
Copy Markdown
Member

Since you are modifying the build system: Did you notice that current builds show up with Large File Support (LFS): no? See e.g.: https://github.com/OSGeo/grass/actions/runs/18658480388/job/53193250341#step:10:275
Here: https://github.com/OSGeo/grass/actions/runs/18549653323/job/52874607114 it was stil enabled by default... Is that a regression that warrants a new issue?

@marisn

marisn commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

Since you are modifying the build system: Did you notice that current builds show up with Large File Support (LFS): no? See e.g.: https://github.com/OSGeo/grass/actions/runs/18658480388/job/53193250341#step:10:275 Here: https://github.com/OSGeo/grass/actions/runs/18549653323/job/52874607114 it was stil enabled by default... Is that a regression that warrants a new issue?

Yes, that is a regression. LFS detection works, but reporting – doesn't. Here's a PR with the fix: #6537

@marisn

marisn commented Oct 22, 2025

Copy link
Copy Markdown
Contributor

We don’t have to, but using different versions lead to unrelated changes (cluttered history). The version is only of importance for us devs, as it now stands, so whichever is more convenient.

I was more thinking of downstream packagers as on some distros they discard our shipped configure file and generate their own. Now they will be forced to use 2.72, though 2.71 should work just fine as they don't contribute back their configure files. But probably it doesn't matter that much.

@echoix

echoix commented Oct 23, 2025

Copy link
Copy Markdown
Member

@nilason Would you want to rerun the autoreconf again, since the LFS fix up PR was merged?

@nilason

nilason commented Oct 29, 2025

Copy link
Copy Markdown
Contributor Author

We don’t have to, but using different versions lead to unrelated changes (cluttered history). The version is only of importance for us devs, as it now stands, so whichever is more convenient.

I was more thinking of downstream packagers as on some distros they discard our shipped configure file and generate their own. Now they will be forced to use 2.72, though 2.71 should work just fine as they don't contribute back their configure files. But probably it doesn't matter that much.

Browsing on repology.org, the platforms delivering 8.4 all are accompanied by autoconf 2.72, so this shouldn't be a problem for 8.5.

@nilason

nilason commented Oct 29, 2025

Copy link
Copy Markdown
Contributor Author

@nilason Would you want to rerun the autoreconf again, since the LFS fix up PR was merged?

There wouldn't be any need for it (as it has been run by 2.72), but I tested to be sure.

@nilason
nilason merged commit 6f92ad1 into OSGeo:main Oct 29, 2025
33 of 37 checks passed
@nilason
nilason deleted the update_autoconf_272 branch October 29, 2025 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants