Add Subsystem and Partition Interfaces for PowerElectronics - #560
Add Subsystem and Partition Interfaces for PowerElectronics#560abdourahmanbarry wants to merge 9 commits into
Conversation
45b0f43 to
c90bae2
Compare
superwhiskers
left a comment
superwhiskers
left a comment
There was a problem hiding this comment.
just an architectural question
| /** | ||
| * @brief Represents a subset of a PowerElectronicsModel that can be evaluated | ||
| * independently. | ||
| * | ||
| * A SubsystemModel contains a collection of existing GridKit components and | ||
| * nodes taken from a larger system. Variables owned by those components and | ||
| * nodes become internal variables of the subsystem. Variables needed by those | ||
| * components but owned outside the subsystem become external coupling | ||
| * variables. | ||
| * | ||
| * Components normally store connection indices in the global system indexing. | ||
| * During subsystem allocation, these indices are temporarily replaced with a | ||
| * contiguous local subsystem indexing so that the subsystem can be evaluated | ||
| * like an independent PowerElectronicsModel. | ||
| * | ||
| * External coupling values must be supplied before residual or Jacobian | ||
| * evaluation, either directly through the external-data vectors or through a | ||
| * forcing function. | ||
| * | ||
| * @todo Find a better name for this class and its base class. | ||
| * | ||
| * @tparam ScalarT Scalar type used by the model. | ||
| * @tparam IdxT Index type used for variable and connection indices. | ||
| */ |
There was a problem hiding this comment.
so, my main question here is why do we need this notion of distinct "systems" and "subsystems" present in the codebase?
when first learning about system partitioning stuff in gridkit, it seemed more natural to me to instead allow the system itself to be a component that can be used in another system. the "non-owning" nature of SubsystemModel as implemented here seems like it could be more naturally captured by a SystemModelRef or some similar type that encapsulates the notion of "referencing" a system model or something like that (perhaps to match the bus partition interface thing for components---SystemModelInterface).
what was the motivation behind this design choice? it seems more natural to build up from smaller components than to break apart.
3 participants
Description
In this PR, we implement
SubsystemModelfor partitioned Power Electronics simulation. The implementation provides the infrastructure required to partition Power Electronics networks, and to evaluate subsystem residuals and Jacobians independently.This is the third of four stacked pull requests that split PR #492 into simpler, more manageable chunks.
Proposed changes
We added a
SubsystemModelclass to represent an individual partition and aBusPartitionInterfacecomponent to mark partition boundaries. Together, these enable us to partition larger networks for co-simulation and parallel function evaluation.Checklist
-Wall -Wpedantic -Wconversion -Wextra.