Skip to content

Eliminate useless state in Genrou and Gensal - #556

Open
lukelowry wants to merge 2 commits into
developfrom
lukel/gen-reduce-dev
Open

Eliminate useless state in Genrou and Gensal#556
lukelowry wants to merge 2 commits into
developfrom
lukel/gen-reduce-dev

Conversation

@lukelowry

@lukelowry lukelowry commented Aug 28, 2026

Copy link
Copy Markdown
Collaborator

Description

Eliminates the algebraic real and imaginary variables that served no purpose. This does not change anything, and the generator still owns its injection current variables.

Proposed changes

  • Eliminate Norton current variables

Checklist

  • All tests pass.
  • Code compiles cleanly with flags -Wall -Wpedantic -Wconversion -Wextra.
  • [ x] The new code follows GridKit™ style guidelines.
  • N/A There are unit tests for the new code.
  • The new code is documented.
  • The feature branch is rebased with respect to the target branch.
  • N/A The CHANGELOG.md has been updated to reflect the changes. If this is a minor PR that is part of a larger fix already included in the file, state so.

Further comments

The documentation was already in the cleaner form, not sure when they diverged

@lukelowry
lukelowry requested a review from nkoukpaizan August 28, 2026 01:55
@nkoukpaizan nkoukpaizan added the bug Something isn't working label Aug 28, 2026
@nkoukpaizan

Copy link
Copy Markdown
Collaborator

A few tests are failing. Likely the ones using the output callback lambda with hard-coded variable indices. We really need to remove those. CC @PhilipFackler

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants