Skip to content

Multiple PVT regions and rock compressibility in compositional Flow #7464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
GitPaean wants to merge 10 commits into
base: master
Choose a base branch
from
+713 −44
Draft

Multiple PVT regions and rock compressibility in compositional Flow #7464

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
d901078
Accept a COMPVD phase change away from the type-1 gas-oil contact
GitPaean Sep 30, 2026
841fd81
Register the COMPVD contact-mismatch regression
GitPaean Oct 2, 2026
c0b31b4
Keep the last vapour row of a two-zone COMPVD table in the gas zone
GitPaean Oct 3, 2026
05492ec
Anchor the water to the hydrocarbon zone at its contact
GitPaean Oct 3, 2026
6437cc5
Tighten the COMPVD zone-boundary checks and messages
GitPaean Oct 3, 2026
139f34f
Apply rock compressibility in the compositional model
GitPaean Sep 28, 2026
4ab87a6
Take the water properties of each cell's PVT region in compositional …
GitPaean Sep 28, 2026
8528fb2
Equilibrate each water column with the water of its PVT region
GitPaean Sep 28, 2026
023e083
Register compositional PVT region regressions
GitPaean Sep 29, 2026
474a2e9
Register shared equilibration PVT region regression
GitPaean Oct 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 18 additions & 0 deletions examples/problems/co2ptflashproblem.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -285,6 +285,24 @@ public:
return Opm::CompositionalConfig::EOSType::PR;
}

template <class Context>
unsigned pvtRegionIndex(const Context&, unsigned, unsigned) const
{
return 0;
}

template <class Context>
Scalar rockCompressibility(const Context&, unsigned, unsigned) const
{
return 0.0;
}

template <class Context>
Scalar rockReferencePressure(const Context&, unsigned, unsigned) const
{
return 1.0e5;
}

/*!
* \copydoc FvBaseProblem::finishInit
*/
Expand Down
11 changes: 10 additions & 1 deletion opm/models/ptflash/flashintensivequantities.hh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -228,6 +228,8 @@ public:

// Update phases
typename FluidSystem::template ParameterCache<Evaluation> paramCache(eos_type);
// the water properties of the cell's PVT region
paramCache.setRegionIndex(problem.pvtRegionIndex(elemCtx, dofIdx, timeIdx));
paramCache.updatePhase(fluidState_, FluidSystem::oilPhaseIdx);
paramCache.updatePhase(fluidState_, FluidSystem::gasPhaseIdx);

Expand Down Expand Up @@ -323,8 +325,15 @@ public:
// Compute the remaining quantities
/////////////

// porosity
// porosity, scaled with the pressure by the rock compressibility of the
// cell's region as in the black-oil model
porosity_ = problem.porosity(elemCtx, dofIdx, timeIdx);
const Scalar rockCompressibility = problem.rockCompressibility(elemCtx, dofIdx, timeIdx);
if (rockCompressibility > 0.0) {
const Scalar rockRefPressure = problem.rockReferencePressure(elemCtx, dofIdx, timeIdx);
const Evaluation x = rockCompressibility * (p - rockRefPressure);
porosity_ *= 1.0 + x + 0.5 * x * x;
}
Valgrind::CheckDefined(porosity_);

// intrinsic permeability
Expand Down
1 change: 1 addition & 0 deletions opm/simulators/flow/FlowProblemComp.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -437,6 +437,7 @@ class FlowProblemComp : public FlowProblem<TypeTag>
getEosType(),
vanguard.cellCenterDepths(),
eqlnum,
this->pvtnum_,
vanguard.gridView().comm(),
this->gravity()[dimWorld - 1],
this->numPressurePointsEquil(),
Expand Down
239 changes: 199 additions & 40 deletions opm/simulators/flow/equil/InitStateEquilComp.hpp
View file
Open in desktop

Large diffs are not rendered by default.

85 changes: 85 additions & 0 deletions regressionTests.cmake
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -218,6 +218,23 @@ add_test_compareECLFiles(
compositional/equilibration
)

add_test_compareECLFiles(
CASENAME
equil_1d_compvd_water_gascap_contact_mismatch
FILENAME
EQUIL_1D_COMPVD_WATER_GASCAP_CONTACT_MISMATCH
SIMULATOR
flow_comp
REFERENCE_SIMULATOR
flow_comp
ABS_TOL
${abs_tol}
REL_TOL
${rel_tol}
DIR
compositional/equilibration
)

add_test_compareECLFiles(
CASENAME
equil_1d_compvd_oil
Expand All @@ -235,6 +252,74 @@ add_test_compareECLFiles(
compositional/equilibration
)

add_test_compareECLFiles(
CASENAME
pvtnum_water
FILENAME
PVTNUM_WATER
SIMULATOR
flow_comp
REFERENCE_SIMULATOR
flow_comp
ABS_TOL
${abs_tol}
REL_TOL
${rel_tol}
DIR
compositional/pvt_regions
)

add_test_compareECLFiles(
CASENAME
pvtnum_equil
FILENAME
PVTNUM_EQUIL
SIMULATOR
flow_comp
REFERENCE_SIMULATOR
flow_comp
ABS_TOL
${abs_tol}
REL_TOL
${rel_tol}
DIR
compositional/pvt_regions
)

add_test_compareECLFiles(
CASENAME
pvtnum_equil_shared
FILENAME
PVTNUM_EQUIL_SHARED
SIMULATOR
flow_comp
REFERENCE_SIMULATOR
flow_comp
ABS_TOL
${abs_tol}
REL_TOL
${rel_tol}
DIR
compositional/pvt_regions
)

add_test_compareECLFiles(
CASENAME
pvtnum_rock
FILENAME
PVTNUM_ROCK
SIMULATOR
flow_comp
REFERENCE_SIMULATOR
flow_comp
ABS_TOL
${abs_tol}
REL_TOL
${rel_tol}
DIR
compositional/pvt_regions
)

add_test_compareECLFiles(
CASENAME
spe12
Expand Down
Loading
Loading