Fix/add action sha - #80
Merged
Merged
Conversation
…docs excluded as other work going on re this workflow)
This was
linked to
issues
Aug 21, 2026
Closed
There was a problem hiding this comment.
Pull request overview
This PR updates GitHub Actions workflows to pin actions by full commit SHA for supply-chain hardening, and introduces automated changelog generation on version tags using git-cliff.
Changes:
- Pin
actions/checkoutandactions/setup-pythonto specific commit SHAs in existing CI/build workflows. - Add a
git-cliffconfiguration (cliff.toml) to generateCHANGELOG.md. - Add a new
changelog_update.ymlworkflow to generate and commit changelog updates on version tag pushes.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
cliff.toml |
Adds git-cliff changelog template and commit parsing rules. |
.github/workflows/python-package.yml |
Pins GitHub Actions dependencies to full commit SHAs in Python CI. |
.github/workflows/package-build.yml |
Pins GitHub Actions dependencies to full commit SHAs in package build workflow. |
.github/workflows/changelog_update.yml |
Adds a tag-triggered workflow to generate, commit, and retag changelog updates. |
Suppressed comments (2)
.github/workflows/changelog_update.yml:21
- The checkout step will run on the tag ref (detached HEAD) for tag pushes, so the subsequent
git push origin HEAD:maincan accidentally movemainto the tag commit history. Check outmainexplicitly before generating/committing the changelog so the push updates the branch you intend.
- name: Checkout Branch
uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262
with:
fetch-depth: 0
token: ${{ secrets.ACCESS_TOKEN }}
.github/workflows/changelog_update.yml:40
INPUT_TAG_NAMEwon't be populated for aworkflow_dispatchinput; as written, manual runs will likely fall back toGITHUB_REF(which isn't a tag ref) and produce the wrong tag name. Use the workflow input (when present) orgithub.ref_namefor tag pushes.
TAG_NAME="${INPUT_TAG_NAME:-${GITHUB_REF#refs/tags/}}"
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Committing Copilot review suggestions Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
Suppressed comments (2)
.github/workflows/changelog_update.yml:24
- Using a PAT (
secrets.ACCESS_TOKEN) for checkout/push can re-trigger workflows on the subsequentgit push/ force-tag, creating an accidental workflow loop. Prefer the built-inGITHUB_TOKENhere (it won’t trigger new workflow runs from its own pushes) unless you have a specific protection-bypass requirement.
- name: Checkout Branch
uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262
with:
fetch-depth: 0
token: ${{ secrets.ACCESS_TOKEN }}
- name: Generate changelog
.github/workflows/python-package.yml:52
- Same indentation issue in the
testsjob: the step list items are not indented understeps:, which will prevent the workflow from parsing.
steps:
- uses: actions/checkout@11d5960a326750d5838078e36cf38b85af677262
- name: Set up Python ${{ matrix.python-version }}
uses: actions/setup-python@a26af69be951a213d495a4c3e4e4022e16d87065
with:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated github workflows to include full commit SHAs rather than versions as per new guidance. Added a workflow to automatically update CHANGELOG.md. This has not been fully tested yet as can only be tested with a tag commit. Deploy docs workflow has not been changed at all due to parallel work ongoing.